refactor: Reduce/remove entity pointers as means of addressing entities #1406
Conversation
|
Managed to get components no longer storing an entity pointer as a member. There is no nice way to say it: This is going to be a major pain when it comes to editing the function calls themselves. |
| * @param objectId Object ID | ||
| * @param entityPtr Entity pointer | ||
| */ | ||
| void AddEntity(const LWOOBJID objectId, Entity* entityPtr) { m_Entities.insert_or_assign(objectId, entityPtr); }; |
There was a problem hiding this comment.
im not sure how much of a fan I am of exposing this API as it implies anyone and thing can add an entity when in reality every single entity must go through create entity first.
| @@ -50,5 +50,5 @@ class Component | |||
| /** | |||
| * The entity that owns this component | |||
| */ | |||
| Entity* m_Parent; | |||
There was a problem hiding this comment.
Why is this being changed? I had thought the agreement was to move this to a ref instead of an objectID
| void GameMessages::SendPlayFXEffect(Entity* entity, int32_t effectID, const std::u16string& effectType, const std::string& name, LWOOBJID secondary, float priority, float scale, bool serialize) { | ||
| SendPlayFXEffect(entity->GetObjectID(), effectID, effectType, name, secondary, priority, scale, serialize); | ||
| } | ||
|
|
||
| void GameMessages::SendPlayFXEffect(const LWOOBJID& entity, int32_t effectID, const std::u16string& effectType, const std::string& name, LWOOBJID secondary, float priority, float scale, bool serialize) { | ||
| void GameMessages::SendPlayFXEffect(const LWOOBJID entityId, const int32_t effectId, const std::u16string& effectType, const std::string& name, const LWOOBJID secondary, const float priority, const float scale, const bool serialize) { |
There was a problem hiding this comment.
LWOOBJID should be passed by ref as it generally doesn't fit into a register is faster to pass anything larger than 4 bytes by reference than to copy it
|
There are a lot of miscelaneous changes in this PR afte doing a quick scan of it, could this be split into some more focussed ones instead to make the review process easier? |
|
I might revisit this, but if so, it won't be with this branch. Closing. |
Working toward an object ID system instead. Entity pointers should not be assumed to be constant, as it would be useful to have the capability to move their locations in memory.