Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Docker Compose README #1403

Merged
merged 8 commits into from
Jan 8, 2024
Merged

fix: Docker Compose README #1403

merged 8 commits into from
Jan 8, 2024

Conversation

Xiphoseer
Copy link
Contributor

@Xiphoseer Xiphoseer commented Jan 6, 2024

This PR moves the Docker Compose section of the README before the Standalone version and updates .env.example and docker-compose.yml to require minimal user intervention to get a server up and running.

To try out, follow the new instructions at https://github.com/DarkflameUniverse/DarkflameServer/blob/fix/docker-readme/README.md#compose

@Xiphoseer Xiphoseer added the A-docker Related to the docker setup label Jan 6, 2024
aronwk-aaron
aronwk-aaron previously approved these changes Jan 7, 2024
@aronwk-aaron
Copy link
Member

tested locally, works great

EmosewaMC
EmosewaMC previously approved these changes Jan 7, 2024
Copy link
Collaborator

@EmosewaMC EmosewaMC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can simply give this a +1 for the fact that it works. someone with further docker knowledge should look at this first before merging though.

@aronwk-aaron aronwk-aaron merged commit fbdcc17 into main Jan 8, 2024
4 checks passed
@aronwk-aaron aronwk-aaron deleted the fix/docker-readme branch January 8, 2024 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-docker Related to the docker setup
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants