Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: make dNet only depend on dCommon libraries #1401

Merged
merged 1 commit into from
Jan 7, 2024
Merged

Conversation

EmosewaMC
Copy link
Collaborator

  • Add structs to communicate between the various functions so the data can be easily passed around to the correct handler
  • Remove code that was dependent on other libraries linking against dNet by using the variables passed into the function instead, inlining the code to the one place it is used (A new issue should be created tracking this code so we can find a proper place for it later) and in one case inlining without a TODO or a struct due to the amount of data needed to be passed between the interfaces, and the fact that Character is a dGame class with multiple serialization types.

Tested that

  • I can still load into worlds
  • See other player positons update with and without mounts or racecars
  • save data is in tact when delivered to my client
  • bad words are rejected from civilians and gms can still bypass in global and friend chat
  • remove cheat detection that isnt a cheat detection and doesn't really do anything anyways
  • help issues are still the same as the strings in the inis

Copy link
Contributor

@Xiphoseer Xiphoseer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! Approved with one optional suggestion

dGame/UserManager.cpp Show resolved Hide resolved
@Xiphoseer Xiphoseer merged commit b683413 into main Jan 7, 2024
4 checks passed
@Xiphoseer Xiphoseer deleted the dep-fixes branch January 7, 2024 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants