Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: change timers to not use ptrs #1399

Merged
merged 1 commit into from
Jan 6, 2024
Merged

Conversation

EmosewaMC
Copy link
Collaborator

add comments as to why logic may seem confusing.

Tested that Spider queen battle can be completed without crashing and that schooner can also be used without error

add comments as to why logic may seem confusing.
@EmosewaMC EmosewaMC changed the title change timers to not use ptrs chore: change timers to not use ptrs Jan 6, 2024
Copy link
Member

@Wincent01 Wincent01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm.

Considering most entities will never use timers, would it be worth moving timers to a component? The entity class has quite a few members at this point, might be worth delegating some responsibility elsewhere. This would regardless be for a future PR.

@aronwk-aaron aronwk-aaron merged commit 14c20fb into main Jan 6, 2024
4 checks passed
@EmosewaMC
Copy link
Collaborator Author

Lgtm.

Considering most entities will never use timers, would it be worth moving timers to a component? The entity class has quite a few members at this point, might be worth delegating some responsibility elsewhere. This would regardless be for a future PR.

Yes. That would be ideal to make this large class smaller, just a bigger change :)

@EmosewaMC EmosewaMC deleted the timers-no-longer-use-ptrs branch January 6, 2024 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants