fix: don't crash if some configs values aren't present #1388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aronwk-aaron
requested review from
DarwinAnim8or,
Xiphoseer,
EmosewaMC and
Jettford
Xiphoseer
previously approved these changes
Jan 4, 2024
EmosewaMC
changed the title
EmosewaMC
changed the title
EmosewaMC
changed the title
EmosewaMC
changed the title
remove not starting if ini's aren't present since everything can run from env vars now
aronwk-aaron
force-pushed
the
fix--make-all-settings-have-sane-defaults-where-possible
branch
from
af7ceb0 to
321d354
Compare
|
retested things, they work. |
EmosewaMC
approved these changes
Jan 5, 2024
Xiphoseer
approved these changes
Jan 5, 2024
DarwinAnim8or
approved these changes
Jan 5, 2024
Xiphoseer
deleted the
fix--make-all-settings-have-sane-defaults-where-possible
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove not starting if ini's aren't present since everything can run from env vars now
tested running a server with no ini's and the db connector game proper feedback
tested running with only the MYSQL_XXXX configs set as env vars and the server ran perfect and I was able to connect with a client