feat: partially functioning property behavior ui (no saving or loading yet) #1384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add SendBehaviorBlocksToClient serialization add id generation and auto updating add behaviorlisttoclient serialization
Use proper encapsulation to hide code away and only let specific objects do certain jobs.
Section off into operational chunks Write data at the level most appropriate
Remove pointer usage for BlockDefinitions and move to optional.
remove const from return value change to int from uint use generic methods to reduce code clutter
fix an issue where if you were on an empty state, the server would allow you to remain on that state fix an issue where the ui would not open on the previously opened state fix an issue where deleting strips in order caused the wrong strips to be deleted
constify serialize further include path fixes use const, comments fix amf message Update ModelComponent.cpp replace operator subscript with at
|
latest commit doesnt really make the include path smaller, but allows more work to be done in parallel |
Xiphoseer
previously approved these changes
Jan 3, 2024
its precompiled, but just in case
Xiphoseer
approved these changes
Jan 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the property behavior UI to be functional.
Does not implement saving or loading of behaviors.
Tested iteratively and at the end all messages in all (i believe all) contexts and did not spot any errors. Fortunately, there are little pointers being accessed in behavior contexts outside of serialization, so any faults will be in vector accesses failing with their respective .ats. The UI when you make changes and close the window should now save those changes on the local world for that behavior. If you remove the behavior the changes will be lost. If you shutdown the world the behavior will be lost. If you pickup the model the behaviors will be lost. This feature is not a small one and will take time for all the pieces to come together.