feat: get & print std::current_exception #1366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EmosewaMC
reviewed
Dec 29, 2023
EmosewaMC
reviewed
Dec 29, 2023
|
Windows does also produce the mdmp file which contains the current exception and much more info, so its ok if this doesn't apply to windows |
Xiphoseer
force-pushed
the
feature/print-current-exception
branch
2 times, most recently
from
282bf11 to
458665b
Compare
Xiphoseer
force-pushed
the
feature/print-current-exception
branch
from
458665b to
2a8145b
Compare
aronwk-aaron
approved these changes
Dec 30, 2023
EmosewaMC
approved these changes
Dec 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves the linux diagnostics code to print the current exception if there is one. This would probably work on windows as well, but this matches the
std::set_terminatecall, and as far as I can tell, the windows code does something else entirely.c.f. https://en.cppreference.com/w/cpp/error/exception_ptr