chore: rename rebuild to quickbuild #1364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aronwk-aaron
requested review from
DarwinAnim8or,
Wincent01,
EmosewaMC and
Jettford
EmosewaMC
reviewed
Dec 28, 2023
There was a problem hiding this comment.
I have left some feedback suggesting that we punt the changes not related to renaming these files, even if I think they are fine, if we are touting this as just a "rename" with "non-function" changes, we should hold ourselves to that to reduce the risk of a change this large back firing.
aronwk-aaron
force-pushed
the
re-to-quick
branch
from
537082d to
610989a
Compare
EmosewaMC
approved these changes
Dec 29, 2023
Jettford
approved these changes
Dec 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is a non-function change
tested that quickbuilds still work and spot checked some of the scripts that use QB's as well
rebuild are a legacy pre-alpha gameplay feature that got re-worked into quickbuilds
renaming this to avoid confusion with things, since quickbuild is the common way to refer to them