chore: make scripted activity derived from activity #1363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this paves the way for other component being properly derived from the activity component
aronwk-aaron
force-pushed
the
chore--make-scripted-activity-drived-from-activity
branch
from
da3bd63 to
913b844
Compare
aronwk-aaron
requested review from
DarwinAnim8or,
Wincent01,
EmosewaMC and
Jettford
aronwk-aaron
commented
Dec 28, 2023
Jettford
previously approved these changes
Dec 28, 2023
Jettford
previously approved these changes
Dec 28, 2023
EmosewaMC
approved these changes
Dec 28, 2023
Jettford
approved these changes
Dec 29, 2023
aronwk-aaron
deleted the
chore--make-scripted-activity-drived-from-activity
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this paves the way for other component being properly derived from the activity component
Some docs on this on this branch
Tested that scripted activities such as foot races and the combat challenge still work as expected