Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Eradicate C-style casts and further clean up some code #1361

Merged
merged 13 commits into from
Dec 28, 2023
Merged

chore: Eradicate C-style casts and further clean up some code #1361

merged 13 commits into from
Dec 28, 2023

Conversation

jadebenn
Copy link
Collaborator

Kills pretty much all the C-style casts in our code base. Marking as draft until I have time to finish playtesting all the features this PR touches.

EmosewaMC
EmosewaMC reviewed Dec 26, 2023
View reviewed changes
dCommon/Diagnostics.cpp Outdated Show resolved Hide resolved
EmosewaMC
EmosewaMC reviewed Dec 26, 2023
View reviewed changes
dCommon/NiPoint3.cpp Outdated Show resolved Hide resolved
@jadebenn jadebenn marked this pull request as ready for review December 26, 2023 23:14
Remove the c-style cast warning I added from CMakeLists now that they…
c82a4cc 
…'re gone (it triggers on 3rd party dependencies and slows down compilation)
@jadebenn jadebenn requested a review from EmosewaMC December 26, 2023 23:43
EmosewaMC
EmosewaMC reviewed Dec 27, 2023
View reviewed changes
dCommon/Diagnostics.cpp Outdated Show resolved Hide resolved
EmosewaMC
EmosewaMC reviewed Dec 27, 2023
View reviewed changes
dCommon/NiPoint3.cpp Outdated Show resolved Hide resolved
EmosewaMC
EmosewaMC reviewed Dec 27, 2023
View reviewed changes
dCommon/SHA512.cpp Outdated Show resolved Hide resolved
EmosewaMC
EmosewaMC requested changes Dec 27, 2023
View reviewed changes
Copy link
Collaborator

@EmosewaMC EmosewaMC left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff, mostly on board, though there is some feedback that must be addressed, some optionally addressed, and some questions

@jadebenn jadebenn requested a review from EmosewaMC December 27, 2023 22:49
EmosewaMC
EmosewaMC reviewed Dec 27, 2023
View reviewed changes
Copy link
Collaborator

@EmosewaMC EmosewaMC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Has this been tested to progress missions and not underfloor on shooting gallery?

@jadebenn
Copy link
Collaborator Author

Tested both and they seem to work fine.

aronwk-aaron
aronwk-aaron previously approved these changes Dec 28, 2023
View reviewed changes
@aronwk-aaron aronwk-aaron merged commit ef6f2f1 into DarkflameUniverse:main Dec 28, 2023
3 checks passed
@jadebenn jadebenn deleted the CodeCleanup2 branch December 28, 2023 04:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EmosewaMC EmosewaMC EmosewaMC approved these changes

@aronwk-aaron aronwk-aaron aronwk-aaron approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jadebenn @aronwk-aaron @EmosewaMC