Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Falling from Spider Cave now smashes you #1302

Merged
merged 1 commit into from
Nov 18, 2023

Conversation

jadebenn
Copy link
Collaborator

Fixes #1282. Tested by jumping off the cliff repeatedly.

Copy link
Collaborator

@EmosewaMC EmosewaMC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you check deaths in other scenarios? Racing, enemies and various others as well? This GM is sent in more than 1 scenario so its good to check bounds

@jadebenn
Copy link
Collaborator Author

Not sure how to enter the racing instances with one player... Is there an easier way to test besides logging in with two accounts?

@EmosewaMC
Copy link
Collaborator

Not sure how to enter the racing instances with one player... Is there an easier way to test besides logging in with two accounts?

worldconfig.ini

@jadebenn
Copy link
Collaborator Author

Death in racing works as expected.

@jadebenn
Copy link
Collaborator Author

"Smash me" works as well

@aronwk-aaron aronwk-aaron merged commit 7bbe5ff into DarkflameUniverse:main Nov 18, 2023
3 checks passed
@jadebenn jadebenn deleted the FixSpiderCaveDie branch November 18, 2023 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: Death plane in Advent Gardens spider cave does not function
3 participants