Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Dismantling of models taking many many more resources than necessary #1295

Merged
merged 2 commits into from
Nov 16, 2023

Conversation

EmosewaMC
Copy link
Collaborator

allows the user to only send a maximum of numUniqueBricksInModel gms to their client when dismantling a model instead of numBricksInModel * numModelsToDismantle gms. The difference here is literally sending 30ish gms at the most vs 1.5 million.

Tested that the client doesn't crash due to dismantling so many models

Copy link
Member

@aronwk-aaron aronwk-aaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

packets go brrrrr

@aronwk-aaron aronwk-aaron merged commit 8b270ca into main Nov 16, 2023
3 checks passed
@aronwk-aaron aronwk-aaron deleted the fix-dismantling branch November 16, 2023 01:29
@MustacheMan2
Copy link

MustacheMan2 commented Nov 18, 2023

I am finding that this fix has made crashes more frequent

@EmosewaMC
Copy link
Collaborator Author

Are you just going to say its more frequent or are you going to say what is causing it as well?

@EmosewaMC
Copy link
Collaborator Author

if you are talking about getting kicked to login, please ensure UGCUSE3DSERVICES is set to 7:0 and that your game is in a folder called client.

@EmosewaMC
Copy link
Collaborator Author

I have found an item with the issue. I would appreciate just being given the item that has an issue rather than a vague hint that there are issues still as it doesnt happen with most models.

@MustacheMan2
Copy link

Sorry about my previous comment, I knew at the time that my comment wasn't especially helpful and I still posted it for some reason, I just couldn't be bothered to provide evidence. The issue I'm having is also a server crash, not a client crash, so I'm just going to quietly walk away lol

@EmosewaMC
Copy link
Collaborator Author

regardless its fixed now, please confirm the fix on your end if possible

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants