fix: Ugc Add subkey for rockets and cars #1266
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables cars and rockets to actually be able to load images for their preview icons in the inventory. does not handle image generation. This will need to be handled by the end user or a 3rd party.
Tested that, if a user has followed the guide and turned UGCUSE3DSERVICES from 1 to 0, the do not get booted to login for having a rocket or a car with a subkey in their inventory; in this case, the rocket or car will never try to load an image and will always use the default.
If however, UGCUSE3DSERVICES is set to 1, the following behavior is correct as per the live client (and a sample from an old client with a rocket image).
Tested that, given a subkey of
1152921508901867691
, the client expects a file called UserMade/691/01152921508901867691.dds in the UserMade folder and when a dds is placed in the folder with that name and path, the client properly renders the rocket/car with said image. (file format is last 3 digits of the subkey as the folder number and then subkey.dds).Even if this file exists, but UGCUSE3DSERVICES is set to 0, then no images will ever be loaded, even if they exist and are correct.