fix: Ugc Remove async and second id usage #1265
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optimized writes and reads to use aligned reads and writes to save time not looping.
Removed async code as the destructor of a std::future will block at the end of the function, causing it to block and removing its purpose, the code being run by it is async anyways, so it served no purpose anyways
Removed second persistentid generation that is unnecessary for ugc models as we overwrote it anyways with something new.
The pictured model well above a singular sd0 chunk size was able to be built, saved and downloaded when requested without issues.