Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Ugc Remove async and second id usage #1265

Merged
merged 1 commit into from
Nov 7, 2023
Merged

fix: Ugc Remove async and second id usage #1265

merged 1 commit into from
Nov 7, 2023

Conversation

EmosewaMC
Copy link
Collaborator

Optimized writes and reads to use aligned reads and writes to save time not looping.
Removed async code as the destructor of a std::future will block at the end of the function, causing it to block and removing its purpose, the code being run by it is async anyways, so it served no purpose anyways
Removed second persistentid generation that is unnecessary for ugc models as we overwrote it anyways with something new.

image
The pictured model well above a singular sd0 chunk size was able to be built, saved and downloaded when requested without issues.

@EmosewaMC EmosewaMC changed the title Ugc: Remove async and second id usage fix: Ugc Remove async and second id usage Nov 6, 2023
Copy link
Member

@DarwinAnim8or DarwinAnim8or left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good changes-- this code was some of the last I wrote while working on this project originally and it was more about getting anything working so BBB could be considered "functional" before release.

Wrapping it in async was I think just done on a whim because it seemed logical to make a big call like this async. Aside from that, ReadAlignedBytes and similar are indeed a proper way to do this, I just hadn't thought of it at the time; makes me wonder if there's other spaces where we could do it

ANYWAY LGTM TY EMO

@DarwinAnim8or DarwinAnim8or merged commit 4c10faa into main Nov 7, 2023
3 checks passed
@EmosewaMC EmosewaMC deleted the ugc_patch branch November 7, 2023 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants