fix: Players are able to join a race without having a race car #1149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed RacingControlComponent to boot players back to the hub world when trying to race after dismantling a vehicle.
EmosewaMC
reviewed
Jul 20, 2023
EmosewaMC
reviewed
Jul 20, 2023
EmosewaMC
reviewed
Jul 22, 2023
aronwk-aaron
changed the title
EmosewaMC
approved these changes
Oct 9, 2023
aronwk-aaron
approved these changes
Oct 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DESC: Changed RacingControlComponent to boot players back to the hub world when trying to race after dismantling a vehicle.
MOTIVATION: Avoid players being stuck indefinitely when trying to load into a race after dismantling a vehicle and starting the race
CHANGES: Code added to the block for identifying the player's vehicle. If the vehicle pointer is null, then rather than simply returning, it will now put the player back into the hub world where the race was accessed, and update the race instance to remove the player from the loading queue so the race can continue for other players who do have their vehicles properly equipped.
TESTING: Tested solo, with two players, and with three players. Test results were successful.
Fixes #780