refactor: re-write AOE, add FilterTargets, Update TacArc Reading #1035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aronwk-aaron
force-pushed
the
make-filterTarget-better
branch
from
67a4511 to
c415d05
Compare
Update Tacarc to use new filter targets Added dev commands for skill and attack debugging
rather than controllable physics Since destroyables are what can be hit
aronwk-aaron
requested review from
EmosewaMC,
MickVermeulen,
Jettford and
Wincent01
aronwk-aaron
commented
Mar 30, 2023
Closed
|
Converting to draft to re-write using the logic the client does with passing one vector as a reference to filter and the list being populated outside of that filter. |
reduce memory usage by only using one vector and removing invalid entries get entities in the proximity rather than all entities with des comps in the instance, as was done in live
|
re-tested everything listed in the original comment |
EmosewaMC
reviewed
Apr 1, 2023
add pvp checks to isenemy
aronwk-aaron
changed the title
aronwk-aaron
changed the title
EmosewaMC
approved these changes
Oct 9, 2023
Jettford
approved these changes
Oct 9, 2023
|
Looks all good, a few notes about programming practices passed along but nothing worth blocking over. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-write AOE behavior for new filter targets
Update Tacarc to use new filter targets
Added dev commands for skill and attack debugging
Tested that changes to tac arc only affect filtered enemies.
Removed hardcoded logic to add faction to the includeFactionsList for lot 14466
Tested that the skill from 14466 will hit players (Rain of Fire attack in the spider boss battle).
Tested that AOE filter and sorting targets works as expected given the filter parameters
Targets are hit from closest to furthest up to the max target count.