default-initialize message-id buffer to an invalid (but defined) stat…

…e and trust the compiler to optimize it out
DarkflameUniverse · Nov 22, 2024 · 051a0ba · 051a0ba
1 parent 5aa8b13
commit 051a0ba
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/dCommon/dEnums/MessageType/World.h b/dCommon/dEnums/MessageType/World.h
@@ -5,7 +5,8 @@
 
 namespace MessageType {
 	enum class World : uint32_t {
-		VALIDATION = 1,  // 				Session info
+		INVALID = 0,
+		VALIDATION,  // 				Session info
 		CHARACTER_LIST_REQUEST,
 		CHARACTER_CREATE_REQUEST,
 		LOGIN_REQUEST,  // 			Character selected

diff --git a/dWorldServer/WorldServer.cpp b/dWorldServer/WorldServer.cpp
@@ -1397,7 +1397,7 @@ void HandlePacket(Packet* packet) {
 
 	default:
 		// Need to use memcpy instead of reinterpret_cast to avoid UB
-		MessageType::World messageId;
+		auto messageId = MessageType::World::INVALID;
 		std::memcpy(&messageId, &packet->data[3], sizeof(MessageType::World));
 
 		const std::string_view messageIdString = StringifiedEnum::ToString(messageId);