Skip to content

Commit

Permalink
feat!: upgrade mysql charset and collation to utf8mb4
Browse files Browse the repository at this point in the history
  • Loading branch information
Danyal-Faheem committed Jun 14, 2024
1 parent 4a84e66 commit 73b3d38
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 5 deletions.
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
- 💥[Feature] Upgrade default charset and collation of mysql to utf8mb4 and utf8mb4_unicode_ci respectively (by @Danyal-Faheem)
2 changes: 1 addition & 1 deletion tutor/templates/apps/openedx/config/partials/auth.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ DATABASES:
OPTIONS:
init_command: "SET sql_mode='STRICT_TRANS_TABLES'"
{%- if RUN_MYSQL %}
charset: "utf8mb3"
charset: "utf8mb4"
{%- endif %}
EMAIL_HOST_USER: "{{ SMTP_USERNAME }}"
EMAIL_HOST_PASSWORD: "{{ SMTP_PASSWORD }}"
4 changes: 2 additions & 2 deletions tutor/templates/k8s/deployments.yml
Original file line number Diff line number Diff line change
Expand Up @@ -394,8 +394,8 @@ spec:
image: {{ DOCKER_IMAGE_MYSQL }}
args:
- "mysqld"
- "--character-set-server=utf8mb3"
- "--collation-server=utf8mb3_general_ci"
- "--character-set-server=utf8mb4"
- "--collation-server=utf8mb4_general_ci"
- "--binlog-expire-logs-seconds=259200"
env:
- name: MYSQL_ROOT_PASSWORD
Expand Down
4 changes: 2 additions & 2 deletions tutor/templates/local/docker-compose.yml
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,8 @@ services:
image: {{ DOCKER_IMAGE_MYSQL }}
command: >
mysqld
--character-set-server=utf8mb3
--collation-server=utf8mb3_general_ci
--character-set-server=utf8mb4
--collation-server=utf8mb4_general_ci
--binlog-expire-logs-seconds=259200
restart: unless-stopped
user: "999:999"
Expand Down

0 comments on commit 73b3d38

Please sign in to comment.