Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add query options and improve query execution #39

Merged
merged 1 commit into from
Aug 12, 2024

Conversation

Daniel-Boll
Copy link
Owner

This commit introduces a new QueryOptions structure that allows users to specify whether a query should be prepared or not. The execute method in ScyllaSession has been updated to handle these options and decide whether to prepare a query or not based on the provided options. This improves the performance of queries that need to be prepared before execution.

Additionally, helper methods have been added to handle the execution of prepared statements and direct queries separately, improving code readability and maintainability.

The TypeScript definitions and examples have also been updated to reflect these changes.

Signed-off-by: Daniel Boll [email protected]

This commit introduces a new QueryOptions structure that allows users to specify whether a query should be prepared or not. The execute method in ScyllaSession has been updated to handle these options and decide whether to prepare a query or not based on the provided options. This improves the performance of queries that need to be prepared before execution.

Additionally, helper methods have been added to handle the execution of prepared statements and direct queries separately, improving code readability and maintainability.

The TypeScript definitions and examples have also been updated to reflect these changes.

Signed-off-by: Daniel Boll <[email protected]>
@Daniel-Boll Daniel-Boll self-assigned this Aug 12, 2024
@Daniel-Boll Daniel-Boll linked an issue Aug 12, 2024 that may be closed by this pull request
Copy link
Collaborator

@DanielHe4rt DanielHe4rt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Daniel-Boll Daniel-Boll merged commit 048c17a into main Aug 12, 2024
4 checks passed
@Daniel-Boll Daniel-Boll deleted the feat/prepared-option branch August 12, 2024 14:11
Daniel-Boll pushed a commit that referenced this pull request Nov 9, 2024
* ci: update

* Update lint.yml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feature: allow prepared statements directly on session.execute
2 participants