Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetch schema #33

Merged
merged 4 commits into from
Jul 31, 2024
Merged

Fetch schema #33

merged 4 commits into from
Jul 31, 2024

Conversation

Matozinho
Copy link
Collaborator

@Matozinho Matozinho commented Jul 31, 2024

No description provided.

…intainability by adding line breaks to long statements and improving code structure

feat(index.d.ts): add new classes ClusterDataSimplified, KeyspaceSimplified, TableSimplified, MaterializedViewSimplified to provide simplified cluster and keyspace information
feat(index.js): update exports to include new classes ClusterDataSimplified, KeyspaceSimplified, TableSimplified, MaterializedViewSimplified for better module organization and clarity

feat(scylla_session.rs): add support for simplified data structures to improve readability and maintainability of the codebase.

Signed-off-by: Felipi Lima Matozinho <[email protected]>
…ating keyspace and table

feat(basic.mts): add support for fetching and displaying keyspace and table information
feat(fetch-schema.mts): add new file to fetch and display keyspace and table information

refactor(scylla_session.rs): restructure code to improve readability and maintainability by renaming structs and methods for better semantics and clarity. Update struct names to match their purpose and improve consistency in naming conventions.

Signed-off-by: Felipi Lima Matozinho <[email protected]>
…r into feature/fetch-schema

Signed-off-by: Felipi Lima Matozinho <[email protected]>
@Matozinho Matozinho added the enhancement New feature or request label Jul 31, 2024
@Matozinho Matozinho requested a review from Daniel-Boll July 31, 2024 15:30
@Matozinho Matozinho self-assigned this Jul 31, 2024
@Matozinho Matozinho linked an issue Jul 31, 2024 that may be closed by this pull request
examples/fetch-schema.mts Outdated Show resolved Hide resolved
src/session/scylla_session.rs Outdated Show resolved Hide resolved
src/session/scylla_session.rs Outdated Show resolved Hide resolved
@Daniel-Boll
Copy link
Owner

Remember to manually run cargo fmt & cargo clippy before commit, just in case.

…bility and error handling

feat(session): add topology module to handle cluster topology information
feat(session): move ScyllaClusterData struct to topology module for better organization and separation of concerns

feat(topology.rs): add support for defining Scylla cluster data, keyspace, strategy, table, and materialized view structures to interact with Scylla database.

Signed-off-by: Felipi Lima Matozinho <[email protected]>
@Matozinho Matozinho requested a review from Daniel-Boll July 31, 2024 18:44
Copy link
Owner

@Daniel-Boll Daniel-Boll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Daniel-Boll Daniel-Boll merged commit 6e7930d into main Jul 31, 2024
4 checks passed
@Daniel-Boll Daniel-Boll deleted the feature/fetch-schema branch July 31, 2024 18:51
Daniel-Boll pushed a commit that referenced this pull request Nov 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fetch schema (Not Fully Documented Issue)
2 participants