per_move_pressure_advance extruder flag #132
Merged
+30
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rogerlz
force-pushed
the
store_pa_in_trapq_flag
branch
from
20db67e
to
490efe1
Compare
bwnance
force-pushed
the
store_pa_in_trapq_flag
branch
from
8cb999e
to
41d889c
Compare
bwnance
changed the title
rogerlz
previously approved these changes
Jan 29, 2024
rogerlz
approved these changes
Jan 29, 2024
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
basically a flag to revert Klipper3d/klipper@29724a7 and allow pressure advance to come through trapq
should resolve Klipper3d/klipper#6338
in theory, the change in Klipper3d/klipper@29724a7 can introduce about 250ms of lag after changing pressure advance, which can reduce performance when printing very fast and frequently changing pressure advance while printing (ie variable pressure advance in role-based gcode)
to enable, add to [extruder]:
per_move_pressure_advance: True