Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create org plan , when an org is created. #1321

Merged
merged 5 commits into from
Nov 26, 2024
Merged

Create org plan , when an org is created. #1321

merged 5 commits into from
Nov 26, 2024

Conversation

himanshudube97
Copy link
Contributor

  1. Org plan fields added to create org form

@himanshudube97 himanshudube97 changed the base branch from main to settings-pannel-ui November 19, 2024 21:28
@himanshudube97 himanshudube97 marked this pull request as draft November 19, 2024 21:29
@himanshudube97 himanshudube97 self-assigned this Nov 19, 2024
@himanshudube97 himanshudube97 linked an issue Nov 21, 2024 that may be closed by this pull request
Org Creation flow to include OrgPlan creation (frontend) #1315
Closed
Base automatically changed from settings-pannel-ui to main November 24, 2024 10:14
@himanshudube97 himanshudube97 changed the title Issues and enhancements mentioned in the settings panel doc Create org plan , when an org is created. Nov 25, 2024
@himanshudube97 himanshudube97 marked this pull request as ready for review November 26, 2024 11:34
@codecov Codecov
Copy link

codecov bot commented Nov 26, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 57.77778% with 19 lines in your changes missing coverage. Please review.

Project coverage is 71.25%. Comparing base (710a733) to head (06bfd17).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
src/components/Org/CreateOrgForm.tsx 46.87% 17 Missing ⚠️
src/components/Settings/SubscriptionInfo.tsx 84.61% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1321      +/-   ##
==========================================
- Coverage   71.47%   71.25%   -0.22%     
==========================================
  Files         102      102              
  Lines        7099     7132      +33     
  Branches     1557     1623      +66     
==========================================
+ Hits         5074     5082       +8     
+ Misses       1995     1932      -63     
- Partials       30      118      +88

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@himanshudube97 himanshudube97 requested review from fatchat and removed request for Ishankoradia November 26, 2024 12:13
fatchat
fatchat reviewed Nov 26, 2024
View reviewed changes
src/components/Org/__tests__/CreateOrgForm.test.tsx
expect(setShowForm).toHaveBeenCalledWith(false);
});
});
// it('submits the form correctly and handles the response', async () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did we just give up over here

@fatchat fatchat merged commit b3771bb into main Nov 26, 2024
3 of 5 checks passed
@fatchat fatchat deleted the issues-resolve-settings-panel branch November 26, 2024 12:44
@himanshudube97 himanshudube97 linked an issue Nov 26, 2024 that may be closed by this pull request
Handle OrgPlan with start date with no end date #1329
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fatchat fatchat fatchat approved these changes

Assignees

@himanshudube97 himanshudube97

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Handle OrgPlan with start date with no end date Org Creation flow to include OrgPlan creation (frontend)
2 participants
@himanshudube97 @fatchat