cmake: only use _FORTIFY_SOURCE with hardening #1456
+1
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
illwieckz
force-pushed
the
illwieckz/hardening
branch
from
f7ce889 to
aa32c01
Compare
|
This makes most builds less secure just to fix warnings on one obscure use case. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That test was almost always true (well, except with non-release MinGW builds no one run).
The previous code means that
_FORTIFY_SOURCEwas used on MinGW on recent releases becauseUSE_HARDENINGis used.I don't really know what that tes meant anyway.
I noticed this because doing ASAN build on macOS spammed lots of warning that
_FORTIFY_SOURCEwas redefined. It looks like an ASAN build on macOS forces a different_FORTIFY_SOURCEvalue so we need to be able to disable it, something we can do by disabling hardening.