VirtualMachine: make receive timeout configurable #1449
Merged
+8
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
illwieckz
force-pushed
the
illwieckz/receive-timeout
branch
from
e06f011 to
28a4efe
Compare
slipher
reviewed
Nov 24, 2024
illwieckz
force-pushed
the
illwieckz/receive-timeout
branch
from
28a4efe to
a4d0eac
Compare
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make receive timeout configurable.
I used this to make sure the Saigo-compiled code was stuck in an infinite loop and not just slower.
It may also help when loading the game from a very slow file system (like network file system over Internet), because the time waiting for the first receive is waiting for the nexe to be actually loaded (downloaded if a network file system).