Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Port main] #3624 - Fix Multi-Row Drag-and-Drop Issue for Chips in Item Submission Form #3769

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dspace-bot
Copy link
Contributor

Port of #3654 by @Simone-Ramundi to main.

@dspace-bot dspace-bot added 1 APPROVAL pull request only requires a single approval to merge bug component: submission labels Dec 19, 2024
@tdonohue tdonohue added this to the 9.0 milestone Dec 19, 2024
@nwoodward
Copy link
Contributor

@tdonohue @Simone-Ramundi Before this gets ported to main I want to ask about this comment in the PR for dspace-8_x.

This issue arises because the current version (17.3.10) of Angular Material’s cdkDropList does not natively support multi-row. Support of multiple row has been added to Angular 18.
So for DSpace 9 the fix can be done when upgrading to Angular 18. While in DSpace 8, which uses an earlier Angular version, we need a custom fix.

Does that mean the PR does not need to be ported to main because it will be fixed automatically by upgrading to Angular 18 (#3717)?

@tdonohue
Copy link
Member

Good question, @nwoodward . I don't know the answer myself, but I'll refrain from merging this into main until we are certain it needs to be merged there.

@Simone-Ramundi , let us know if this should be merged into main or not. It may be that this automatic port PR can simply be closed if we don't need it on main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 APPROVAL pull request only requires a single approval to merge bug component: submission
Projects
Status: 👍 Reviewer Approved
Development

Successfully merging this pull request may close these issues.

4 participants