Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GitHub Actions][Docker] Update Docker scripts & GitHub Actions to use ghcr.io instead of docker.io #3754

Merged
merged 4 commits into from
Dec 16, 2024

Conversation

tdonohue
Copy link
Member

References

Description

This small PR updates the following:

Instructions for Reviewers

  • The changes in this PR will all be tested in the automated build/test process. Therefore, if this passes all automated tests, it can be merged safely.

@tdonohue tdonohue added code task 1 APPROVAL pull request only requires a single approval to merge port to dspace-7_x This PR needs to be ported to `dspace-7_x` branch for next bug-fix release port to dspace-8_x This PR needs to be ported to `dspace-8_x` branch for next bug-fix release labels Dec 16, 2024
@tdonohue tdonohue added this to the 9.0 milestone Dec 16, 2024
@tdonohue
Copy link
Member Author

Merging as this passes all automated tests. Verified that this results in e2e tests using the images from ghcr.io instead of those from docker.io.

This will need to be ported (either automatically or manually) to 8.x and 7.x

@tdonohue tdonohue merged commit 5a71902 into DSpace:main Dec 16, 2024
15 checks passed
@tdonohue tdonohue added the backend: Docker related to DSpace deployment via Docker label Dec 16, 2024
@dspace-bot
Copy link
Contributor

Backport failed for dspace-7_x, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin dspace-7_x
git worktree add -d .worktree/backport-3754-to-dspace-7_x origin/dspace-7_x
cd .worktree/backport-3754-to-dspace-7_x
git switch --create backport-3754-to-dspace-7_x
git cherry-pick -x 4575c3d7afd15d433a023e209b7bcb5e776e2adb 0d516bfe9c706ec10ed9ebe9a936210999232912 bad57def74b6ade16b4a1fb164d14394c5bc6618 dab6b1c12e3dd0f960145dde230fd6d6108af58e

@dspace-bot
Copy link
Contributor

Backport failed for dspace-8_x, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin dspace-8_x
git worktree add -d .worktree/backport-3754-to-dspace-8_x origin/dspace-8_x
cd .worktree/backport-3754-to-dspace-8_x
git switch --create backport-3754-to-dspace-8_x
git cherry-pick -x 4575c3d7afd15d433a023e209b7bcb5e776e2adb 0d516bfe9c706ec10ed9ebe9a936210999232912 bad57def74b6ade16b4a1fb164d14394c5bc6618 dab6b1c12e3dd0f960145dde230fd6d6108af58e

@tdonohue
Copy link
Member Author

Manual port to 7.x: #3756 and 8.x #3755

@tdonohue tdonohue removed port to dspace-7_x This PR needs to be ported to `dspace-7_x` branch for next bug-fix release port to dspace-8_x This PR needs to be ported to `dspace-8_x` branch for next bug-fix release labels Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 APPROVAL pull request only requires a single approval to merge backend: Docker related to DSpace deployment via Docker code task
Projects
Status: ✅ Done
2 participants