Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Port dspace-8_x] Removed observable function calls from template (part 1) #3738

Conversation

alexandrevryghem
Copy link
Member

Manual port of #3585 & #3720 to dspace-8_x

@alexandrevryghem alexandrevryghem added bug high priority performance / caching Related to performance, caching or embedded objects component: Item (Archived) Item display or editing claimed: Atmire Atmire team is working on this issue & will contribute back labels Dec 9, 2024
@alexandrevryghem alexandrevryghem added this to the 8.1 milestone Dec 9, 2024
@alexandrevryghem alexandrevryghem self-assigned this Dec 9, 2024
@MW3000
Copy link
Contributor

MW3000 commented Dec 17, 2024

I did test this pull request on DSpace 8.1-Snapshot

Verify that all these functionalities still work correctly:
EPerson pages
Group pages
Bitstream Format Registry
Metadata Registry
A component that uses the pagination component

I did successfully open all the pages listed above and I successfully used components with pagination.
I am not sure how much in-depth test is necessary for those pages? I did successfully add bitstream formats and metadata formats.

Copy link
Member

@tdonohue tdonohue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexandrevryghem : Thanks! Overall this looks good and works. But, when I tested this locally, I noticed I'm seeing an odd error in my Chrome Dev Tools with this PR installed. I cannot reproduce these same error on demo.dspace.org (running latest from dspace-8_x).

Here's what I'm doing and what I see:

  • First, I'm running things in production mode: yarn run build:prod; yarn run serve:ssr
  • Open up Chrome Dev Tools
  • Visit the homepage. No errors in Chrome Dev Tools
  • Now, login as any user, and you'll see an error like this in Chrome Dev Tools:
main.34ada579bae23bc2.js:1 ERROR Error: {"actuator":{"href":"http://localhost:8080/server/actuator"},"authn":{"href":"http://localhost:8080/server/api/authn"},"authorizations":{"href":"http://localhost:8080/server/api/authz/authorizations"},"bitstreamformats":{"href":"http://localhost:8080/server/api/core/bitstreamformats"},"bitstreams":{"href":"http://localhost:8080/server/api/core/bitstreams"},"browses":{"href":"http://localhost:8080/server/api/discover/browses"},"bulkaccessconditionoptions":{"href":"http://localhost:8080/server/api/config/bulkaccessconditionoptions"},"bundles":{"href":"http://localhost:8080/server/api/core/bundles"},"claimedtasks":{"href":"http://localhost:8080/server/api/workflow/claimedtasks"},"claimedtasks-search":{"href":"http://localhost:8080/server/api/workflow/claimedtasks/search"},"collections":{"href":"http://localhost:8080/server/api/core/collections"},"communities":{"href":"http://localhost:8080/server/api/core/communities"},"contentreport":{"href":"http://localhost:8080/server/api/contentreport"},"correctiontypes":{"href":"http://localhost:8080/server/api/config/correctiontypes"},"discover":{"href":"http://localhost:8080/server/api/discover"},"dso":{"href":"http://localhost:8080/server/api/dso/find{?uuid}","templated":true},"duplicates":{"href":"http://localhost:8080/server/api/submission/duplicates"},"duplicates-search":{"href":"http://localhost:8080/server/api/submission/duplicates/search"},"enqueueretry":{"href":"http://localhost:8080/server/api/ldn/messages/{id}/enqueueretry","templated":true},"entitytypes":{"href":"http://localhost:8080/server/api/core/entitytypes"},"eperson-registration":{"href":"http://localhost:8080/server/api/eperson/registrations"},"epersons":{"href":"http://localhost:8080/server/api/eperson/epersons"},"externalsources":{"href":"http://localhost:8080/server/api/integration/externalsources"},"features":{"href":"http://localhost:8080/server/api/authz/features"},"feedbacks":{"href":"http://localhost:8080/server/api/tools/feedbacks"},"groups":{"href":"http://localhost:8080/server/api/eperson/groups"},"identifiers":{"href":"http://localhost:8080/server/api/pid/identifiers"},"itemfilters":{"href":"http://localhost:8080/server/api/config/itemfilters"},"itemrequests":{"href":"http://localhost:8080/server/api/tools/itemrequests"},"items":{"href":"http://localhost:8080/server/api/core/items"},"itemtemplates":{"href":"http://localhost:8080/server/api/core/itemtemplates"},"ldnservices":{"href":"http://localhost:8080/server/api/ldn/ldnservices"},"messages":{"href":"http://localhost:8080/server/api/ldn/messages"},"metadatafields":{"href":"http://localhost:8080/server/api/core/metadatafields"},"metadataschemas":{"href":"http://localhost:8080/server/api/core/metadataschemas"},"notifyrequests":{"href":"http://localhost:8080/server/api/ldn/notifyrequests"},"oidc":{"href":"http://localhost:8080/server/api/authn"},"orcidhistories":{"href":"http://localhost:8080/server/api/eperson/orcidhistories"},"orcidqueues":{"href":"http://localhost:8080/server/api/eperson/orcidqueues"},"pid":{"href":"http://localhost:8080/server/api/pid/find{?id}","templated":true},"pooltasks":{"href":"http://localhost:8080/server/api/workflow/pooltasks"},"pooltasks-search":{"href":"http://localhost:8080/server/api/workflow/pooltasks/search"},"processes":{"href":"http://localhost:8080/server/api/system/processes"},"properties":{"href":"http://localhost:8080/server/api/config/properties"},"qualityassuranceevents":{"href":"http://localhost:8080/server/api/integration/qualityassuranceevents"},"qualityassurancesources":{"href":"http://localhost:8080/server/api/integration/qualityassurancesources"},"qualityassurancetopics":{"href":"http://localhost:8080/server/api/integration/qualityassurancetopics"},"registrations":{"href":"http://localhost:8080/server/api/eperson/registrations"},"relationships":{"href":"http://localhost:8080/server/api/core/relationships"},"relationshiptypes":{"href":"http://localhost:8080/server/api/core/relationshiptypes"},"resourcepolicies":{"href":"http://localhost:8080/server/api/authz/resourcepolicies"},"resourcepolicies-search":{"href":"http://localhost:8080/server/api/authz/resourcepolicies/search"},"scripts":{"href":"http://localhost:8080/server/api/system/scripts"},"self":{"href":"http://localhost:8080/server/api"},"sites":{"href":"http://localhost:8080/server/api/core/sites"},"statistics":{"href":"http://localhost:8080/server/api/statistics"},"submissionaccessoptions":{"href":"http://localhost:8080/server/api/config/submissionaccessoptions"},"submissioncclicenseUrls":{"href":"http://localhost:8080/server/api/config/submissioncclicenseUrls"},"submissioncclicenseUrls-search":{"href":"http://localhost:8080/server/api/config/submissioncclicenseUrls/search"},"submissioncclicenses":{"href":"http://localhost:8080/server/api/config/submissioncclicenses"},"submissioncoarnotifyconfigs":{"href":"http://localhost:8080/server/api/config/submissioncoarnotifyconfigs"},"submissiondefinitions":{"href":"http://localhost:8080/server/api/config/submissiondefinitions"},"submissionforms":{"href":"http://localhost:8080/server/api/config/submissionforms"},"submissionsections":{"href":"http://localhost:8080/server/api/config/submissionsections"},"submissionuploads":{"href":"http://localhost:8080/server/api/config/submissionuploads"},"subscriptions":{"href":"http://localhost:8080/server/api/core/subscriptions"},"subscriptions-search":{"href":"http://localhost:8080/server/api/core/subscriptions/search"},"suggestions":{"href":"http://localhost:8080/server/api/integration/suggestions"},"suggestionsources":{"href":"http://localhost:8080/server/api/integration/suggestionsources"},"suggestiontargets":{"href":"http://localhost:8080/server/api/integration/suggestiontargets"},"supervisionorders":{"href":"http://localhost:8080/server/api/core/supervisionorders"},"systemwidealerts":{"href":"http://localhost:8080/server/api/system/systemwidealerts"},"usagereports":{"href":"http://localhost:8080/server/api/statistics/usagereports"},"versionhistories":{"href":"http://localhost:8080/server/api/versioning/versionhistories"},"versions":{"href":"http://localhost:8080/server/api/versioning/versions"},"vocabularies":{"href":"http://localhost:8080/server/api/submission/vocabularies"},"vocabularyEntryDetails":{"href":"http://localhost:8080/server/api/submission/vocabularyEntryDetails"},"vocabularyEntryDetails-search":{"href":"http://localhost:8080/server/api/submission/vocabularyEntryDetails/search"},"workflowactions":{"href":"http://localhost:8080/server/api/config/workflowactions"},"workflowdefinitions":{"href":"http://localhost:8080/server/api/config/workflowdefinitions"},"workflowitems":{"href":"http://localhost:8080/server/api/workflow/workflowitems"},"workflowsteps":{"href":"http://localhost:8080/server/api/config/workflowsteps"},"workspaceitems":{"href":"http://localhost:8080/server/api/submission/workspaceitems"}} doesn't contain the link profiles
    at main.34ada579bae23bc2.js:1:279204
    at main.34ada579bae23bc2.js:1:1897441
    at c._next (main.34ada579bae23bc2.js:1:1893835)
    at c.next (main.34ada579bae23bc2.js:1:1882666)
    at main.34ada579bae23bc2.js:1:1897434
    at c._next (main.34ada579bae23bc2.js:1:1893835)
    at c.next (main.34ada579bae23bc2.js:1:1882666)
    at main.34ada579bae23bc2.js:1:1901895
    at c._next (main.34ada579bae23bc2.js:1:1893835)
    at c.next (main.34ada579bae23bc2.js:1:1882666)

I've also noticed this same error is occurring on main. So, I'm starting to suspect it's an accidental side effect of the code in this PR (and in #3585).

Overall, I'm +1 this PR. I'm not against merging this as-is, but then I'd want to open up a follow-up ticket to ensure this console error is fixed.

@alexandrevryghem
Copy link
Member Author

@tdonohue: That issue is not related to this PR, it's pretty old and has been on my TODO list for a while 😅. You can see that this currently also occurs on the dspace-8_x branch in the e2e tests

@tdonohue
Copy link
Member

@alexandrevryghem : In that case, I'll create a separate ticket for this bug. This port looks good besides that error, so I'll merge it as-is. Thanks again!

Copy link
Member

@tdonohue tdonohue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Verified code is an accurate port. Gave it a quick test and everything is working well. Thanks @alexandrevryghem

@tdonohue tdonohue merged commit df79a99 into DSpace:dspace-8_x Dec 18, 2024
13 checks passed
@tdonohue
Copy link
Member

tdonohue commented Dec 18, 2024

@alexandrevryghem alexandrevryghem deleted the w2p-117573_remove-observable-function-calls-from-template_contribute-8_x branch December 18, 2024 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug claimed: Atmire Atmire team is working on this issue & will contribute back component: Item (Archived) Item display or editing high priority performance / caching Related to performance, caching or embedded objects
Projects
Development

Successfully merging this pull request may close these issues.

3 participants