Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#10053: Add support for PCI Endorsement workflow #3735

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

amgciadev
Copy link
Contributor

@amgciadev amgciadev commented Dec 9, 2024

References

Add references/links to any related issues or PRs. These may include:

Description

This PR fixes the issues described in DSpace/DSpace#10053 and provides better support for the PCI Endorsement workflow

Instructions for Reviewers

List of changes in this PR:

  • Modifies the service creation form to add support for the usesActorEmailId parameter (to allow the configuration of the service in cases where the submitter email needs to be sent in the LDN notifications)
  • Modifies signposting model to allow exposing the profile attribute in signposting describedBy typed links

Include guidance for how to test or review your PR. This may include: steps to reproduce a bug, screenshots or description of a new feature, or reasons behind specific changes.

Checklist

This checklist provides a reminder of what we are going to look for when reviewing your PR. You do not need to complete this checklist prior creating your PR (draft PRs are always welcome).
However, reviewers may request that you complete any actions in this list if you have not done so. If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!

  • My PR is created against the main branch of code (unless it is a backport or is fixing an issue specific to an older branch).
  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes ESLint validation using npm run lint
  • My PR doesn't introduce circular dependencies (verified via npm run check-circ-deps)
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • My PR aligns with Accessibility guidelines if it makes changes to the user interface.
  • My PR uses i18n (internationalization) keys instead of hardcoded English text, to allow for translations.
  • My PR includes details on how to test it. I've provided clear instructions to reviewers on how to successfully test this fix or feature.
  • If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

@tdonohue tdonohue added bug integration: COAR Notify / LDN Related to Linked Data Notifications (LDN) or COAR Notify services port to dspace-8_x This PR needs to be ported to `dspace-8_x` branch for next bug-fix release labels Dec 9, 2024
@tdonohue
Copy link
Member

tdonohue commented Dec 9, 2024

@abollini or @atarix83 : I'm assigning this to you because it's improvements to COAR Notify to support PCI better. Could you or someone on your team take a look at this / test it out?

@tdonohue tdonohue requested review from abollini and atarix83 December 9, 2024 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug integration: COAR Notify / LDN Related to Linked Data Notifications (LDN) or COAR Notify services port to dspace-8_x This PR needs to be ported to `dspace-8_x` branch for next bug-fix release
Projects
Status: 🙋 Needs Reviewers Assigned
Development

Successfully merging this pull request may close these issues.

COAR Notify: add support for PCI endorsement workflows
2 participants