Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed dropdown/lookup & lookup-name fields being reset when hitting enter #3724

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fixed dropdown/lookup & lookup-name fields being reset when hitting enter #3724

wants to merge 3 commits into from
+12 −6

Conversation

alexandrevryghem
Copy link
Member

References

Description

Fixed issue where hitting enter in a submission form containg a dropdown/lookup or lookup-name field would cause the first one to reset.

Instructions for Reviewers

List of changes in this PR:

  • Added type="button" to the buttons in those dropdowns, this prevents them from being triggered on submit
  • Also added another small fix to the FormService class. The AbstractControl's errors property can be null when there are no errors, and this caused an issue when it was null because then Object.keys(null) was being called

Checklist

  • My PR is created against the main branch of code (unless it is a backport or is fixing an issue specific to an older branch).
  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes ESLint validation using npm run lint
  • My PR doesn't introduce circular dependencies (verified via npm run check-circ-deps)
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • My PR aligns with Accessibility guidelines if it makes changes to the user interface.
  • My PR uses i18n (internationalization) keys instead of hardcoded English text, to allow for translations.
  • My PR includes details on how to test it. I've provided clear instructions to reviewers on how to successfully test this fix or feature.
  • If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

@alexandrevryghem
119799: Prevent submission from updating the dropdown values when hit…
ed4e794 
…ting enter in another input form (onsubmit)
@alexandrevryghem
Merge remote-tracking branch 'alex/w2p-122005_fixed-dropdown-values-r…
c12a3e6 
…esetting-on-enter_contribute-7.6'

# Conflicts:
#	src/app/shared/form/builder/ds-dynamic-form-ui/models/scrollable-dropdown/dynamic-scrollable-dropdown.component.html
@alexandrevryghem
119799: Prevent the lookup/lookup-name fields from resetting when hit…
c8694e1 
…ting the enter key in another input field
@alexandrevryghem alexandrevryghem added bug component: submission component: controlled vocabulary related to controlled vocabulary or value-pairs dropdowns port to dspace-7_x This PR needs to be ported to `dspace-7_x` branch for next bug-fix release port to dspace-8_x This PR needs to be ported to `dspace-8_x` branch for next bug-fix release labels Dec 7, 2024
@alexandrevryghem alexandrevryghem added this to the 9.0 milestone Dec 7, 2024
@alexandrevryghem alexandrevryghem self-assigned this Dec 7, 2024
@tdonohue tdonohue added the 1 APPROVAL pull request only requires a single approval to merge label Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@alexandrevryghem alexandrevryghem

Labels
1 APPROVAL pull request only requires a single approval to merge bug component: controlled vocabulary related to controlled vocabulary or value-pairs dropdowns component: submission port to dspace-7_x This PR needs to be ported to `dspace-7_x` branch for next bug-fix release port to dspace-8_x This PR needs to be ported to `dspace-8_x` branch for next bug-fix release
Projects
DSpace 9.0 Release
Status: 🙋 Needs Reviewers Assigned
Milestone
9.0
Development

Successfully merging this pull request may close these issues.

Dropdown/lookup & lookup-name values are reset when hitting enter
2 participants
@alexandrevryghem @tdonohue