Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating Hungarian translations for DSpace 8.0 #3714

Merged
merged 4 commits into from
Dec 19, 2024

Conversation

kanasznagyzoltan
Copy link

Description

Updating Hungarian translations for DSpace 8.0. Translating a lot of non-translated values and fixing some weird automatic translations.

Instructions for Reviewers

  • Pull my changes on the hu.json5 file
  • Start the dspace-angular frontend
  • Change the language from English to Hungarian

@tdonohue tdonohue added i18n / l10n Internationalisation and localisation, related to message catalogs 1 APPROVAL pull request only requires a single approval to merge labels Dec 4, 2024
@msutya
Copy link

msutya commented Dec 17, 2024

Tested it. New translations appear correctly. Looking through them, I couldn't find grammatical errors either

@tdonohue tdonohue added the port to main This PR needs to be ported to `main` branch for the next major release label Dec 17, 2024
Copy link
Member

@tdonohue tdonohue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks @kanasznagyzoltan !

@tdonohue tdonohue added this to the 8.1 milestone Dec 19, 2024
@tdonohue tdonohue merged commit 6ce17e0 into DSpace:dspace-8_x Dec 19, 2024
13 checks passed
@dspace-bot
Copy link
Contributor

Backport failed for main, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin main
git worktree add -d .worktree/backport-3714-to-main origin/main
cd .worktree/backport-3714-to-main
git switch --create backport-3714-to-main
git cherry-pick -x 97cda8f75200d4da184d6061f964b0ae724ea0c3 907a16ca09a9f7c5a689c264f84bc9ec0b55316c 964c085ee27186ceceab83d51c79eeb31edd430c b86d0a083af1694780990362c52b82802ad5b8d8

@tdonohue
Copy link
Member

@kanasznagyzoltan : Could you please create a version of this PR for our main branch as well? This was unable to be ported automatically (see above error), so it will have to be done manually. Otherwise, the changes you've made will only be in 8.1 and will be missing from 9.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 APPROVAL pull request only requires a single approval to merge i18n / l10n Internationalisation and localisation, related to message catalogs port to main This PR needs to be ported to `main` branch for the next major release
Projects
Development

Successfully merging this pull request may close these issues.

4 participants