-
Notifications
You must be signed in to change notification settings - Fork 437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Complete tag translations in french for ORCID and Researcher Profile #3590
Conversation
Contains all french translations for ORCID and Researcher Profile.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All the added French translations for ORCID and Researcher Profile reviewed and checked.
@pilasou : This looks good overall, but it cannot be merged because of linting errors. You should be able to see them by running Once those errors are fixed, the automated tests should pass & we can merge this. Thanks! |
@tdonohue I just changed all the indent problems. I hope all tests will pass! I unsure how to use the npm run lint command, but fortunatly the indent problems were easy to spot. |
@pilasou : It's closer now ! Just two lint errors remain. You can fix them manually, or you could try running |
Hi @tdonohue I corrected the 2 remaining errors. Should be ok now. I know how to better read test results for Lint errors! I will also run the test before committing changes! |
Successfully created backport PR for |
Successfully created backport PR for |
References
Add references/links to any related issues or PRs. These may include:
Description
Those french translations focus only on the ORCID module and Researcher Profile feature.