Fix Klaro translations by forcing Klaro to use a zy language code that DSpace will translate

[tdonohue]

References

• Related to DSpace cookie messages are not used, instead the default Klaro messages are used #2027
• Broken since upgrade to Klaro 0.7.19. See "No translation" build contains all the translations klaro-org/klaro-js#515
• Fixes Cookie dialog has a strange text in current DSpace 8.1 Snapshot #3618

Description

After upgrading to Klaro 0.7.19 (or later), our custom message translations are no longer loading into Klaro. This can be seen on both https://sandbox.dspace.org and https://demo.dspace.org because the Klaro Cookie pop-up shows the default Klaro text like this:

The main issue is that the Klaro 'zz' "default translations" no longer seem to work. The reason is because Klaro only uses the zz translations if no other languages can be found, and (as of 0.7.19) the klaro-no-translations package is wrongly including all the translations (see klaro-org/klaro-js#515). So, there's no longer a way to tell Klaro to not include translations and therefore to only use the zz language code.

This PR fixes the issue by changing our Klaro configuration to force Klaro to always use a (different, fake) language code of zy. In our Klaro configuration, we then use our i18n keys for the zy language, and translate it to the user's language as we did before.

Instructions for Reviewers

• Verify the Klaro cookie popup works as before. It's easiest to verify by opening the homepage in an Incognito window.

This bug does NOT impact 7.6.2 or 8.0 (as they both used Klaro 0.7.18). However, it does impact main, dspace-8_x and dspace-7_x as they all now use Klaro 0.7.21 (and this Klaro bug began with 0.7.19).

[MW3000]

I cherrypicked the commit to DSpace 8 and it worked and fixed the problem. 👍

[github-actions]

Hi @tdonohue,
Conflicts have been detected against the base branch.
Please resolve these conflicts as soon as you can. Thanks!

[tdonohue]

Closing, as this needs to be implemented for only dspace-8_x and dspace-7_x because main is now using Orejime (see #3199)