[Port dspace-7_x] Remove unused dependencies (& additional Mirador dependency cleanup) #3574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdonohue
added
dependencies
tdonohue
force-pushed
the
remove_unused_deps_7x
branch
from
036f17f to
021221d
Compare
|
Hi @tdonohue, |
…endencies. Only needed to avoid yarn install warnings
tdonohue
force-pushed
the
remove_unused_deps_7x
branch
from
c20c705 to
eedaa2c
Compare
|
Merging as this is applying the approved fixes in #3553 to dspace-8_x. The new changes to move Mirador dependencies to the "dev" dependencies is a minor change, which I've fully tested by ensuring that IIIF / Mirador viewer still works with this PR. All automated tests also pass. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Port of #3553 and #3573 to
dspace-7_x.This PR contains similar changes as #3573, except applied to
dspace-7_x. See that PR for details on the changes, especially those related to Mirador / IIIF dependencies.The only differences with #3573 are that this PR has two fewer commits. These commits cannot be applied to 7.x:
browser-syncdoes not need to be removed from 7.x, because it doesn't exist in the 7.xpackage.jsonangular-idle-preloadcannot be removed from 7.x because it is used in 7.xInstructions for Reviewers
dspace-7_xbranch!