Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused dependencies (sortablejs, sanitize-html, webfontloader) #3509

Merged
merged 3 commits into from
Oct 22, 2024

Conversation

tdonohue
Copy link
Member

@tdonohue tdonohue commented Oct 21, 2024

Description

While working with dependabot to update our dependencies, I realized that there are three dependencies that are entirely unused in our codebase (and don't appear to have any other dependencies that require them)

  • sortablejs (previously used in reorder of subject terms in submission form. Replaced in Upgrade to angular 16 #2871 ?)
  • sanitize-html (previously used in markdown code, but we now use Angular's built in sanitizer.)
  • webfontloader (possibly used to load web fonts back when we used a Google font? No longer used)

I've fully tested this locally, including submission forms, markdown, and theming. No issues found.

This needs to be ported to main and possibly to dspace-7_x. I plan to do both, but they'll likely need to be done manually.

Instructions for Reviewers

  • Verify tests all still succeed.
  • If desired, test the UI. However, I've already done this.

@tdonohue tdonohue added dependencies Pull requests that update a dependency file 1 APPROVAL pull request only requires a single approval to merge port to main This PR needs to be ported to `main` branch for the next major release port to dspace-7_x This PR needs to be ported to `dspace-7_x` branch for next bug-fix release labels Oct 21, 2024
@tdonohue tdonohue added this to the 8.1 milestone Oct 21, 2024
@tdonohue
Copy link
Member Author

NOTE: I've verified that sortablejs and sanitize-html are both still used in 7.6.x. So, they can only be removed from 8.x and later.

@tdonohue tdonohue removed port to main This PR needs to be ported to `main` branch for the next major release port to dspace-7_x This PR needs to be ported to `dspace-7_x` branch for next bug-fix release labels Oct 21, 2024
Copy link
Member Author

@tdonohue tdonohue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Passes all tests. I verified this is working locally. Also the 7.x version of this PR was already approved/merged. Merging immediately.

@tdonohue tdonohue merged commit c5c9abe into DSpace:dspace-8_x Oct 22, 2024
13 checks passed
@tdonohue tdonohue deleted the remove_unused_deps branch October 22, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 APPROVAL pull request only requires a single approval to merge dependencies Pull requests that update a dependency file
Projects
Development

Successfully merging this pull request may close these issues.

1 participant