Upgrade to Cypress 13.15.0 #3315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdonohue
added
dependencies
tdonohue
commented
Sep 10, 2024
…testing if tab is active. Fix small bug in login-modal test.
tdonohue
force-pushed
the
upgrade_cypress
branch
from
771ff13 to
b543b32
Compare
|
Merging this immediately as it solves a security vulnerability in the development environment, and this only touches e2e tests. |
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin dspace-7_x
git worktree add -d .worktree/backport-3315-to-dspace-7_x origin/dspace-7_x
cd .worktree/backport-3315-to-dspace-7_x
git switch --create backport-3315-to-dspace-7_x
git cherry-pick -x 59ba031b1f733aa43576a042ad639f5ded6f7ca3 f9911ce5ba125e28e81cb5338dd887f6d892fe91 7aba69edd6c345ad48045748940390eb964a8961 968c5bda7158e874bb248361e39d39f732996f7d a012e4cea25423fed9bce67aafaa4e7432c58b41 b543b32a373dcae05bfe529f6f8353b627aed15b b4d932a91b07a781510d4cfa54aad30dfe218c5c |
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin dspace-8_x
git worktree add -d .worktree/backport-3315-to-dspace-8_x origin/dspace-8_x
cd .worktree/backport-3315-to-dspace-8_x
git switch --create backport-3315-to-dspace-8_x
git cherry-pick -x 59ba031b1f733aa43576a042ad639f5ded6f7ca3 f9911ce5ba125e28e81cb5338dd887f6d892fe91 7aba69edd6c345ad48045748940390eb964a8961 968c5bda7158e874bb248361e39d39f732996f7d a012e4cea25423fed9bce67aafaa4e7432c58b41 b543b32a373dcae05bfe529f6f8353b627aed15b b4d932a91b07a781510d4cfa54aad30dfe218c5c |
tdonohue
added
the
testing framework
tdonohue
removed
port to dspace-7_x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Description
Upgrades us to Cypress 13.15.0 which also resolves a security alert related to Cypress v12 (NOTE: This alert doesn't impact production as Cypress is only used to run e2e tests.)
In addition to the Cypress upgrade, the following minor changes were made to ensure better e2e test stability:
item-edit.cy.tsto check that the proper tab is active. This solves some random e2e failures which were occurring when an accessibility scan was triggered before the tabs were fully loaded on the page. This check forces Cypress to wait for the tabs to appear before proceeding.login-modal.cy.tsto fix a minor bug & to simplify the CSS selectors.command.tsto simplify CSS selectors. (The CSS selector cleanup here & above is just minor cleanup that can be done now that Header, navbar, and admin sidebar refactoring #2676 is merged, because we no longer have duplicate elements in the DOM)Instructions for Reviewers