Fixes incorrect operation of the keyword selection field with < and , on the Submission page #3247
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @tdonohue , I'm @jtimal partner, I like to share this PR with you, the above pull request (#3108) has a bug in the local project, so I created a new pull request from branch 8 to avoid the bug.
References
Description
I changed the current validation for tag component in on keyup function for validate the keys "ENTER", "," and ";" for add the tags to Chips template.
Instructions for Reviewers
I added validation for the keys "," and ";" add the labels to the chip template because the current functionality splits the value using the keys mentioned above so I think it is the correct way to validate as it causes an error if we don't validate by those keys incorrectly separating those values, i attach an example:
Grabacion.de.pantalla.2024-06-07.a.la.s.6.43.42.p.m.mov
With validation I simplified the separation of values.
List of changes in this PR:
To review and check:
Create a new item or edit item
Enter a keyword with the symbol , or <
Checklist
yarn lint
yarn check-circ-deps
)package.json
), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.