Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes incorrect operation of the keyword selection field with < and , on the Submission page #3247

Open
wants to merge 2 commits into
base: dspace-8_x
Choose a base branch
from

Conversation

VictorHugoDuranS
Copy link
Contributor

@VictorHugoDuranS VictorHugoDuranS commented Aug 10, 2024

Hi @tdonohue , I'm @jtimal partner, I like to share this PR with you, the above pull request (#3108) has a bug in the local project, so I created a new pull request from branch 8 to avoid the bug.

References

Description

I changed the current validation for tag component in on keyup function for validate the keys "ENTER", "," and ";" for add the tags to Chips template.

Instructions for Reviewers

I added validation for the keys "," and ";" add the labels to the chip template because the current functionality splits the value using the keys mentioned above so I think it is the correct way to validate as it causes an error if we don't validate by those keys incorrectly separating those values, i attach an example:

Grabacion.de.pantalla.2024-06-07.a.la.s.6.43.42.p.m.mov

With validation I simplified the separation of values.

List of changes in this PR:

  • Change the validation considering the keys "," and ";" using the properties keyCode and key of the keyup event

To review and check:
Create a new item or edit item
Enter a keyword with the symbol , or <

Checklist

  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes ESLint validation using yarn lint
  • My PR doesn't introduce circular dependencies (verified via yarn check-circ-deps)
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

@mwoodiupui mwoodiupui changed the title Dspace 8 2679 Repair incorrect operation of the keyword selection field with < and , on the Submission page Aug 12, 2024
@tdonohue tdonohue added bug component: submission 1 APPROVAL pull request only requires a single approval to merge labels Aug 21, 2024
@tdonohue tdonohue added the port to main This PR needs to be ported to `main` branch for the next major release label Aug 21, 2024
@tdonohue tdonohue changed the title Repair incorrect operation of the keyword selection field with < and , on the Submission page Fixes incorrect operation of the keyword selection field with < and , on the Submission page Aug 21, 2024
@tdonohue tdonohue requested a review from atarix83 August 22, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 APPROVAL pull request only requires a single approval to merge bug component: submission port to main This PR needs to be ported to `main` branch for the next major release
Projects
Status: 👀 Under Review
Development

Successfully merging this pull request may close these issues.

3 participants