Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accessibility on the Edit metadata tab #3155

Merged
merged 1 commit into from
Jul 10, 2024
Merged

Accessibility on the Edit metadata tab #3155

merged 1 commit into from
Jul 10, 2024

Conversation

Andrea-Guevara
Copy link
Contributor

References

Description

Addition of the "aria-label" attribute to the add, save, discard and undo buttons on the metadata editing page to ensure that they are "visible" to screen readers, even when the CSS is completely disabled.

Instructions for reviewers

List of changes in this PR:

  • The html of the dso-edit-metadata component has been changed.
  • The "aria-label" attribute has been added to all the buttons in the component.
  • The translation key used in the "title" of each button has been used for "[attr.aria-label]".

To reproduce:

  • Log in to dspace as an administrator.
  • Go to an item and click on the edit button.
  • Go to the "Metadata" section.
  • Check the page with an accessibility tool.

Resolution of issue DSpace#1193 - Addition of the aria-label attribut…
4e783e7 
…e to the add, save, discard and undo buttons on the metadata editing page
@tdonohue tdonohue added bug accessibility 1 APPROVAL pull request only requires a single approval to merge component: Item (Archived) Item display or editing port to dspace-7_x This PR needs to be ported to `dspace-7_x` branch for next bug-fix release port to dspace-8_x This PR needs to be ported to `dspace-8_x` branch for next bug-fix release labels Jul 1, 2024
@Andrea-Guevara Andrea-Guevara mentioned this pull request Jul 1, 2024
Closed
nwoodward
nwoodward approved these changes Jul 3, 2024
View reviewed changes
Copy link
Contributor

@nwoodward nwoodward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Tested and confirmed this PR adds the aria-labels to the buttons.

@tdonohue tdonohue added this to the 9.0 milestone Jul 10, 2024
@tdonohue
Copy link
Member

Merging as this is at +1. Code looks good to me too! Thanks @Andrea-Guevara !

@tdonohue tdonohue merged commit 5a62342 into DSpace:main Jul 10, 2024
13 checks passed
@dspace-bot dspace-bot mentioned this pull request Jul 10, 2024
Merged
@dspace-bot
Copy link
Contributor

Successfully created backport PR for dspace-7_x:

@dspace-bot dspace-bot mentioned this pull request Jul 10, 2024
Merged
@dspace-bot
Copy link
Contributor

Successfully created backport PR for dspace-8_x:

@alexandrevryghem alexandrevryghem removed port to dspace-7_x This PR needs to be ported to `dspace-7_x` branch for next bug-fix release port to dspace-8_x This PR needs to be ported to `dspace-8_x` branch for next bug-fix release labels Nov 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nwoodward nwoodward nwoodward approved these changes

Assignees

@Andrea-Guevara Andrea-Guevara

Labels
1 APPROVAL pull request only requires a single approval to merge accessibility bug component: Item (Archived) Item display or editing
Projects
DSpace 9.0 Release
Status: ✅ Done
Milestone
9.0
Development

Successfully merging this pull request may close these issues.

[Deque Analysis] Item Edit "Metadata" Tab "serious" accessibility issues
5 participants
@Andrea-Guevara @tdonohue @dspace-bot @nwoodward @alexandrevryghem