Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix - Change color Contrast in cookie settings box #3039

Merged
merged 1 commit into from
Jun 14, 2024

Conversation

VictorHugoDuranS
Copy link
Contributor

@VictorHugoDuranS VictorHugoDuranS commented May 10, 2024

References

Description

For resolve comments on PR Cookie setting menu accessibility bug fixed

Instructions for Reviewers

List of changes in this PR:

  • Added --green1 variable style to change the background color on cookie settings
  • Added --green1 in color for hyperlink
  • Text color as dark in the accept button

Using the util : https://webaim.org/resources/contrastchecker/, i found the color constrast for color #333

image

And edit the var color implemented by former by PR mentioned, getting the following

image

Checklist

This checklist provides a reminder of what we are going to look for when reviewing your PR. You need not complete this checklist prior to creating your PR (draft PRs are always welcome). If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!

  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes ESLint validation using yarn lint
  • My PR doesn't introduce circular dependencies (verified via yarn check-circ-deps)
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

@tdonohue tdonohue added bug accessibility 1 APPROVAL pull request only requires a single approval to merge port to dspace-7_x This PR needs to be ported to `dspace-7_x` branch for next bug-fix release labels May 13, 2024
@tdonohue tdonohue added this to the 8.0 milestone May 13, 2024
Copy link
Member

@tdonohue tdonohue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks @VictorHugoDuranS . I've verified this fixes the color contrast issues with the initial "We collection and process..." popup that users will see.

However, I did want to point out that if you click "Customize" on that popup, then you see a list of settings you can customize. That page still fails color contrast because it has a lot of faded gray text on a black background.

So, I'll merge this PR as a partial fix, but I'm leaving the ticket open until we can fully fix the color contrast issues.

See note I added to the original ticket for more details #2668 (comment)

@tdonohue tdonohue added port to main This PR needs to be ported to `main` branch for the next major release and removed port to dspace-7_x This PR needs to be ported to `dspace-7_x` branch for next bug-fix release labels Jun 14, 2024
@tdonohue tdonohue modified the milestones: 8.0, 7.6.2 Jun 14, 2024
@tdonohue tdonohue merged commit 09bf25a into DSpace:dspace-7_x Jun 14, 2024
13 checks passed
@dspace-bot
Copy link
Contributor

Backport failed for main, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin main
git worktree add -d .worktree/backport-3039-to-main origin/main
cd .worktree/backport-3039-to-main
git switch --create backport-3039-to-main
git cherry-pick -x 876ecb1d12e249da0d7dc714cf841558d3246979

@tdonohue tdonohue removed the port to main This PR needs to be ported to `main` branch for the next major release label Jun 14, 2024
@tdonohue
Copy link
Member

Ported to main / 8.0 in #3120

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 APPROVAL pull request only requires a single approval to merge accessibility bug
Projects
Development

Successfully merging this pull request may close these issues.

3 participants