Fixed home page links being unclickable #2945
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Description
In the previous PR I did not realise that the
ds-themed-configuration-search-page
already used theds-page-with-sidebar
. In that PR I added an extrads-page-with-sidebar
around theds-themed-configuration-search-page
causing it's empty floating content column to block clickevents on the components underneath it. This PR refactors the home page to use theds-page-with-sidebar
inside theds-themed-configuration-search-page
instead, this is done with the new content projection selectorsearchContentTop
.Checklist
yarn lint
yarn check-circ-deps
)package.json
), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.