-
Notifications
You must be signed in to change notification settings - Fork 437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
7.x - Header, navbar, and admin sidebar refactoring #2858
Conversation
(cherry picked from commit 8f73b8f)
…ar section (cherry picked from commit f25ec62)
(cherry picked from commit 80cc4c5)
(cherry picked from commit 87d3383)
(cherry picked from commit 46fe7f6)
(cherry picked from commit 523850b)
(cherry picked from commit abba806)
(cherry picked from commit bff93a0)
(cherry picked from commit 8e35c0f)
(cherry picked from commit d1dc8e6)
(cherry picked from commit fdbe7a6)
(cherry picked from commit a88282d)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Thanks @davide-negretti ! I've verified this works for 7.x and it appears to apply all the same fixes as #2676 I've retested all the various accessibility fixes on 7.x and they all appear to have been fixed there as well.
I'm merging this into dspace-7_x
. However, this PR likely requires mention in the 7.6.2 Release Notes because it refactors the header/navbar/side menu. Those refactors may cause some errors to occur in custom themes when sites upgrade from 7.6.1 to 7.6.2
References
Checklist
yarn lint
yarn check-circ-deps
)package.json
), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.