Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Port dspace-7_x] Update dependencies for Node v20 #2849

Merged
merged 1 commit into from
Mar 4, 2024
Merged

[Port dspace-7_x] Update dependencies for Node v20 #2849

merged 1 commit into from
Mar 4, 2024

Conversation

alanorth
Copy link
Contributor

@alanorth alanorth commented Mar 4, 2024

Manual port of #2356 by @mwoodiupui to dspace-7_x.

I've built DSpace 7.6.2-SNAPSHOT with Node.js v20.11.0 and done some basic tests (browse, submit).

@alanorth alanorth added dependencies Pull requests that update a dependency file quick win Pull request is small in size & should be easy to review and/or merge code task 1 APPROVAL pull request only requires a single approval to merge labels Mar 4, 2024
@alanorth alanorth requested a review from tdonohue March 4, 2024 17:31
@alanorth alanorth force-pushed the backport-2356-to-dspace-7_x branch from bc14954 to 3add551 Compare March 4, 2024 17:33
@alanorth alanorth changed the base branch from main to dspace-7_x March 4, 2024 17:34
@DSpace DSpace deleted a comment from github-actions bot Mar 4, 2024
@alanorth
Copy link
Contributor Author

alanorth commented Mar 4, 2024

Oops, I accidentally opened this PR against main and then switched base branches as the test were running and it seems they got stuck. I will try closing and re-opening this PR to trigger them again.

@alanorth alanorth closed this Mar 4, 2024
@alanorth alanorth reopened this Mar 4, 2024
@tdonohue tdonohue added this to the 7.6.2 milestone Mar 4, 2024
tdonohue
tdonohue approved these changes Mar 4, 2024
View reviewed changes
Copy link
Member

@tdonohue tdonohue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks @alanorth ! Tested this locally with Node v18 to make sure that still worked...it does. Merging for 7.6.2

@tdonohue tdonohue merged commit 6fefbe1 into DSpace:dspace-7_x Mar 4, 2024
14 checks passed
@tdonohue tdonohue mentioned this pull request Mar 4, 2024
Merged
8 tasks
@alanorth alanorth deleted the backport-2356-to-dspace-7_x branch March 5, 2024 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tdonohue tdonohue tdonohue approved these changes

Assignees

@alanorth alanorth

Labels
1 APPROVAL pull request only requires a single approval to merge code task dependencies Pull requests that update a dependency file quick win Pull request is small in size & should be easy to review and/or merge
Projects
DSpace 8.x and 7.6.x Maintenance
Archived in project
Milestone
7.6.2
Development

Successfully merging this pull request may close these issues.
2 participants
@alanorth @tdonohue