Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

French translations for missing parameters (access control and batch loading) #2831

Merged
merged 6 commits into from
May 3, 2024
Merged

French translations for missing parameters (access control and batch loading) #2831

merged 6 commits into from
May 3, 2024

Conversation

pilasou
Copy link
Contributor

@pilasou pilasou commented Feb 22, 2024

Description

Addition to the json5 french file to fix missing parameters for access control and batch loading in DSpace.

@pilasou
Update fr.json5 to add access conditions labels
e747520 
Changes to the labels related to access control and access conditions.
@pilasou
Update fr.json5 to add batch upload labels
c4548e6 
Addition of batch upload labels (ZIP, SAF)
@tdonohue tdonohue added i18n / l10n Internationalisation and localisation, related to message catalogs 1 APPROVAL pull request only requires a single approval to merge labels Feb 22, 2024
mhvezina
mhvezina reviewed Feb 23, 2024
View reviewed changes
src/assets/i18n/fr.json5 Outdated


//"admin.access-control.bulk-access-settings.header": "Step 2: Operation to Perform",
"admin.access-control.bulk-access-settings.header": "Étape 2 : Opération à éxecuter",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be "Étape 2 : Opération à exécuter"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in last commit. 46df7e8

mhvezina
mhvezina reviewed Feb 23, 2024
View reviewed changes
src/assets/i18n/fr.json5 Outdated
// "admin.metadata-import.page.help": "You can drop or browse CSV files that contain batch metadata operations on files here",
"admin.metadata-import.page.help": "Vous pouvez glisser-déposer ou rechercher ici des fichiers CSV qui contiennent des opérations en lot sur les métadonnées",

//"admin.batch-import.page.help": "Select the Collection to import into. Then, drop or browse to a Simple Archive Format (SAF) zip file that includes the Items to import",
"admin.batch-import.page.help": "Sélectionner la collection dans laquelle importer les données. Ensuite, ajouter le fichier le fichier zip Simple Archive Format (SAF) contenant tous les Items à importer.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be : "Sélectionner la collection dans laquelle importer les données. Ensuite, ajouter le fichier zip Simple Archive Format (SAF) contenant tous les Items à importer."

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in last commit. 46df7e8

mhvezina
mhvezina reviewed Feb 23, 2024
View reviewed changes
src/assets/i18n/fr.json5 Outdated
"access-control-limit-to-specific": "Limiter les modifications à des Bitstreams spécifiques",

//"access-control-process-all-bitstreams": "Update all the bitstreams in the item",
"access-control-process-all-bitstreams": "Mise à jour de tous les Bitstreams de l'item",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be "Mise à jour de tous les Bitstreams de l'Item"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in last commit. 46df7e8

@mhvezina
Copy link
Contributor

Thank you @pilasou

I added a few suggestions to the translations. @pilasou : you might want to correct your title issue "French rranslations..."

@tdonohue everything else seems good to me!

mhvezina
mhvezina reviewed Feb 23, 2024
View reviewed changes
Copy link
Contributor

@mhvezina mhvezina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#2831 (comment)

@alanorth alanorth changed the title French rranslations for missing parameters (access control and batch loading) French translations for missing parameters (access control and batch loading) Mar 8, 2024
@tdonohue tdonohue self-requested a review April 11, 2024 14:52
@tdonohue
Copy link
Member

@pilasou : This PR appears to be failing lint checks. Could you update it to fix the small issues? They should be visible to you locally by running yarn lint, and you might be able to run yarn lint --fix to fix them automatically. (The automatic fixes don't always work)

@tdonohue
Copy link
Member

@pilasou : There's another lint formatting error now. Here's the new one:

/home/runner/work/dspace-angular/dspace-angular/src/assets/i18n/fr.json5
Lint errors found in the listed files.

  6635:38  error  Parsing error: Unexpected character '“'

It appears to think that one of the double-quotes (") on line 6635 is invalid? Maybe it's accidentally a special character and not a double-quote character? It's unclear to me though because the error isn't obvious when you view this file in GitHub. (My suspicion is maybe this text was copied from a different document like Word and it changed the character)

@tdonohue
Copy link
Member

tdonohue commented May 3, 2024

I've pushed up some additional lint fixes as this still had lint failures. I simply checked out this PR and ran yarn lint --fix to automatically apply the fixes. Once the build succeeds, I'll get this merged & backported to 7.x

@tdonohue tdonohue added the port to dspace-7_x This PR needs to be ported to `dspace-7_x` branch for next bug-fix release label May 3, 2024
@tdonohue tdonohue added this to the 8.0 milestone May 3, 2024
tdonohue
tdonohue approved these changes May 3, 2024
View reviewed changes
Copy link
Member

@tdonohue tdonohue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Tested locally and it works now. Lint also passes

@tdonohue tdonohue merged commit 476e5a5 into DSpace:main May 3, 2024
9 of 11 checks passed
@dspace-bot dspace-bot mentioned this pull request May 3, 2024
Merged
@dspace-bot
Copy link
Contributor

Successfully created backport PR for dspace-7_x:

@tdonohue tdonohue removed the port to dspace-7_x This PR needs to be ported to `dspace-7_x` branch for next bug-fix release label May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhvezina mhvezina mhvezina left review comments

@tdonohue tdonohue tdonohue approved these changes

Assignees

@pilasou pilasou

Labels
1 APPROVAL pull request only requires a single approval to merge i18n / l10n Internationalisation and localisation, related to message catalogs
Projects
No open projects
DSpace 8.0 Release
Status: ✅ Done
Milestone
8.0
Development

Successfully merging this pull request may close these issues.
4 participants
@pilasou @mhvezina @tdonohue @dspace-bot