-
Notifications
You must be signed in to change notification settings - Fork 438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make ItemSearchResultListElementComponent themeable. #2828
Conversation
WIP because, while this met my immediate need, I discovered a number of additional references to this component which I need to update. |
@mwoodiupui Does it solve the same issue? #2651 |
Hi @mwoodiupui, |
Hi @mwoodiupui, |
I'm closing this PR since it's a duplicate of #2651. We should normally never create |
I'm happy to see this fixed. I would have tried to do this the right way if I had known:
It seems to me that the theming support is still opaque in some areas. |
Previously you could easily see that a component was dynamically themeable because they have a custom decorator on top of the component for example An example on how to theme these can be found here |
Description
Make ItemSearchResultListElementComponent themeable.
Instructions for Reviewers
List of changes in this PR:
Include guidance for how to test or review your PR. This may include: steps to reproduce a bug, screenshots or description of a new feature, or reasons behind specific changes.
Checklist
yarn lint
yarn check-circ-deps
)package.json
), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.