Fix browse-by-date year filter option generation

[bkeese]

Empty issued dates incorrectly defaulted to current year instead of lower year limit, resulting in zero year options for the year picker, in turn resulting in a page that never finishes loading.

References

Fixes #2808

Description

A bug in the logic of the browse-by-date year picker resulted in the Browse by Issue Date page never loading.

Instructions for Reviewers

Ensure Browse by Issue Date still works as expected.
Items with empty dc.date.issued should default to the configured browseBy.defaultLowerLimit, not the current year.

Checklist

This checklist provides a reminder of what we are going to look for when reviewing your PR. You need not complete this checklist prior to creating your PR (draft PRs are always welcome). If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!

• My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
• My PR passes ESLint validation using yarn lint
• My PR doesn't introduce circular dependencies (verified via yarn check-circ-deps)
• My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
• My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
• If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
• If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
• If my PR fixes an issue ticket, I've linked them together.

[tdonohue]

As I noted in the original ticket, I'm finding this PR isn't working properly for me. Just wanting to make sure that feedback is also tracked here. See comments at #2808 (comment)

[bkeese]

I plan to make one small tweak to this PR so it handles both cases of missing issue dates. I'll try to do it today.

EDIT: Actually, I am not going to do this yet because this PR seems to fix the problem: #2832

[tdonohue]

Closing, as this bug was just fixed by #2832 , so this PR is no longer needed. See #2808 (comment)