[Port dspace-7_x] Refactored community & collection pages #2800
Conversation
…cated createComponent
…s_contribute-7.6 # Conflicts: # src/app/admin/admin-search-page/admin-search-results/admin-search-result-grid-element/item-search-result/item-admin-search-result-grid-element.component.ts # src/app/admin/admin-workflow-page/admin-workflow-search-results/admin-workflow-search-result-grid-element/workflow-item/workflow-item-search-result-admin-workflow-grid-element.component.ts # src/app/shared/metadata-representation/metadata-representation-loader.component.ts # src/app/shared/mydspace-actions/claimed-task/switcher/claimed-task-actions-loader.component.ts # src/app/shared/theme-support/themed.component.ts
…cated createComponent
…onent-loaders_contribute-7_x # Conflicts: # src/app/shared/theme-support/themed.component.ts
|
Thanks @alexandrevryghem . I'll give this a final review/test once the associated 8.0 PRs are both merged. That way we can make sure to update this if any additional modifications need to be backported. |
There was a problem hiding this comment.
@alexandrevryghem : I tested this backport PR directly, just to verify the fixes are working on dspace-7_x. Overall, it looks good. However, I noticed a very minor aria-current issue with the tabs on Community/Collection pages. See inline comment below.
Overall, I'm +1 this backport. But, it'd be good to fix that ARIA issue if possible.
src/app/shared/comcol/comcol-page-browse-by/comcol-page-browse-by.component.html
Show resolved
Hide resolved
|
@tdonohue: This issue was cause by the |
There was a problem hiding this comment.
👍 Thanks @alexandrevryghem ! Verified this now works the same as the 8.x version. Merging this backport PR immediately.
alexandrevryghem
deleted the
generify-component-loaders_contribute-7_x
branch
Partial port of #2339 & #2722 by @alexandrevryghem to dspace-7_x.
Contains: