[Port dspace-7_x] Fix accessibility issues (part 2) #2786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fixed header ordering - Fixed input field not having a description what it does (because the header isn't always shown I decided to use aria-labels instead of regular labels)
…nt displacement when expanding com/col
- Fixed input not describing itself - Put the items from the dropdown in an ul - Fixed broken aria labels - Removed titles who where identical to the displayed value
- Replaced the h6 tags with the role heading - Gave the gear button the roles in order to be detected as an expandable menu - Replaced the dropdown structure to render a menu of listboxes - Added the aria-selected attribute
- Removed empty label of the select box and replaced it with an aria-label - Fixed empty table header
- Removed empty label of the select box and replaced it with an aria-label - Fixed empty table header
- Removed empty label of the select box and replaced it with an aria-label - Fixed empty table header
- Replaced invisible label in AccessControlArrayFormComponent that was only used for styling with span - Fixed radio buttons not being part of a fieldset - Fixed empty table header
- Hide fontawesome icons for screen readers - Replaced dangling labels with spans and added more descriptive aria label to browse link - Fixed empty label/missing header in edit resource policy table - Added missing comcol logo al text - Refactored dso-edit-menu-section to not display empty link buttons and duplicate titles
- The form used a fieldset tag instead of a form tag
- Hide fontawesome icons for screen readers - Added missing aria-label to metadata field input
- Added the correct autocomplete value - Removed dangling labels, because aria labels already describe those input fields & we can't use ids in this component because otherwise there are duplicate ids on the /login page
- Removed non-existing dropdownMenuButton references - Added appropriate roles to dropdown menus
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Manual) Port of #2717 by @alexandrevryghem to
dspace-7_x.