use localized error message #2736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdonohue
added
bug
i18n / l10n
nwoodward
approved these changes
Jan 18, 2024
tdonohue
approved these changes
Jan 19, 2024
There was a problem hiding this comment.
👍 Thanks @saschaszott ! This seems like a very obvious win. Merging immediately.
|
Successfully created backport PR for |
tdonohue
removed
the
port to dspace-7_x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes the hard coded error message in
AuthServicethat is displayed when a user supplies invalid username and/or password.Please note, that
AuthServicestill contains two other hard coded error messages ("Not authenticated").