-
Notifications
You must be signed in to change notification settings - Fork 438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clear url parameters for entity search tabs #2734
base: main
Are you sure you want to change the base?
Clear url parameters for entity search tabs #2734
Conversation
…p-110878_Entity-search-tabs-clear-params-main
…p-110878_Entity-search-tabs-clear-params-main
Applied an additional fix for #2739, since it's related to the same issue of clearing url parameters. |
Hi @Atmire-Kristof, |
@Atmire-Kristof : This has code conflicts. If you wish to have it still considered for 8.0, please get this PR cleaned up and updated to latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Atmire-Kristof : I tested/reviewed this today. While, I can verify it fixes both #2729 and #2739, this PR is currently failing several existing specs/tests in StartsWithDateComponent
. Please update this PR to either pass those tests or fix those tests.
I don't think #2739 should be considered a bug. The second parameter 'startWith' is used to filter the list of items by title that have the previously selected value. For example, if you select the subject 'financial therapy' on the current demo site (https://demo.dspace.org/browse/subject?value=financial%20therapy&bbm.return=5), you can then filter this list by titles that start with 'Book' (https://demo.dspace.org/browse/subject?value=financial%20therapy&bbm.return=5&bbm.page=1&startsWith=Book). |
References
Description
Clears all url parameters when switching search tabs on entity pages to avoid using non-existent filters/sort/configurations/pages etc. on the new search tab.
Clears url parameters and component properties when applying startsWith or value on browse-by pages, avoiding a conflict between the two described in #2739
Instructions for Reviewers
How to test entity pages:
How to test browse-by pages:
Checklist
This checklist provides a reminder of what we are going to look for when reviewing your PR. You need not complete this checklist prior to creating your PR (draft PRs are always welcome). If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!
yarn lint
yarn check-circ-deps
)package.json
), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.