Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing accesibility issues in the cookie setting #2715

Closed
wants to merge 2 commits into from
Closed

fixing accesibility issues in the cookie setting #2715

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
efd73c9
fixing accesibility issues in the cookie setting
CrisGuzmanS Dec 15, 2023
89aae1c
avoiding :root variable
CrisGuzmanS Dec 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions src/styles/_global-styles.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
:root {
--green1: #4de0b4;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because this is specific to Klaro, we should add a comment here to say something like:

// Specify a different green color for for Klaro cookie notice. ONLY used for Klaro.

Either that, or we see if there's a way to move this color into the .klaro classes below... that may mean not using the variable though and just overriding the CSS colors directly.

Basically though, we need to document why this --green1 exists, so that other developers do NOT use it in other areas of DSpace.

}

html {
position: relative;
min-height: 100%;
Expand Down Expand Up @@ -42,6 +46,12 @@ ds-admin-sidebar {
z-index: 0;
}

.klaro
.cookie-notice
.cm-btn.cm-btn-success {
color: #333333;
}

.media-viewer
.change-gallery
.ngx-gallery
Expand Down
Loading