-
Notifications
You must be signed in to change notification settings - Fork 438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update pt-PT.json5 #2706
Update pt-PT.json5 #2706
Conversation
Addition of new translation keys (following DSpace 7.6.1 release) & revision/improvement of some of the already existing.
Addition of new translation keys (following DSpace 7.6.1 release) & revision/improvement of some of the already existing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @rsaraivac for this contribution! I've just some comments, could you can check if they make sense to you?
src/assets/i18n/pt-PT.json5
Outdated
@@ -332,6 +335,30 @@ | |||
// "admin.registries.schema.title": "Metadata Schema Registry", | |||
"admin.registries.schema.title": "Registo de esquemas de metadados", | |||
|
|||
// "admin.access-control.bulk-access.breadcrumbs": "Bulk Access Management", | |||
"admin.access-control.bulk-access.breadcrumbs": "Gestão do acesso em lote", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you consider to change to:
"Gestão de permissões" or "Gestão de permissões em lote"
src/assets/i18n/pt-PT.json5
Outdated
@@ -215,6 +215,9 @@ | |||
// "admin.registries.bitstream-formats.title": "Bitstream Format Registry", | |||
"admin.registries.bitstream-formats.title": "Registo de formatos de ficheiro", | |||
|
|||
// "admin.registries.bitstream-formats.select": "Select bitstream format", | |||
"admin.registries.bitstream-formats.select": "Selecionar formato de 'bitstream'", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you consider to use "ficheiro" to be coeherent?
src/assets/i18n/pt-PT.json5
Outdated
// "search.filters.namedresourcetype.Workspace": "Workspace", | ||
"search.filters.namedresourcetype.Workspace": "Por terminar", | ||
// "access-control-limit-to-specific": "Limit the changes to specific bitstreams", | ||
"access-control-limit-to-specific": "Limitar as alterações a 'bitstreams' específicos", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you use "ficheiro" instead of "bitstream"?
src/assets/i18n/pt-PT.json5
Outdated
"access-control-limit-to-specific": "Limitar as alterações a 'bitstreams' específicos", | ||
|
||
// "access-control-process-all-bitstreams": "Update all the bitstreams in the item", | ||
"access-control-process-all-bitstreams": "Atualizar todos os 'bitstreams' no item", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you use "ficheiro" instead of "bitstream"?
src/assets/i18n/pt-PT.json5
Outdated
"access-control-process-all-bitstreams": "Atualizar todos os 'bitstreams' no item", | ||
|
||
// "access-control-bitstreams-selected": "bitstreams selected", | ||
"access-control-bitstreams-selected": "bitstreams selecionados", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you use "ficheiro" instead of "bitstream"?
src/assets/i18n/pt-PT.json5
Outdated
"access-control-bitstreams-selected": "bitstreams selecionados", | ||
|
||
// "access-control-bitstreams-select": "Select bitstreams", | ||
"access-control-bitstreams-select": "Selecionar 'bitstreams'", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you use "ficheiro" instead of "bitstream"?
src/assets/i18n/pt-PT.json5
Outdated
"access-control-remove": "Remover condição de acesso", | ||
|
||
// "access-control-select-bitstreams-modal.title": "Select bitstreams", | ||
"access-control-select-bitstreams-modal.title": "Selecionar 'bitstreams'", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you use "ficheiro" instead of "bitstream"?
src/assets/i18n/pt-PT.json5
Outdated
// "mydspace.status.mydspaceWaitingController": "Waiting for Controller", | ||
"mydspace.status.mydspaceWaitingController": "Aguarda validador", | ||
// "access-control-bitstream-toggle.enable": "Enable option to perform changes on the bitstreams", | ||
"access-control-bitstream-toggle.enable": "Ativar a opção para efetuar alterações nos 'bitstreams'", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you use "ficheiro" instead of "bitstream"?
src/assets/i18n/pt-PT.json5
Outdated
// "mydspace.status.mydspaceWorkflow": "Workflow", | ||
"mydspace.status.mydspaceWorkflow": "Em fluxo de trabalho", | ||
// "access-control-bitstream-toggle.disable": "Disable option to perform changes on the bitstreams", | ||
"access-control-bitstream-toggle.disable": "Desativar a opção para efetuar alterações nos 'bitstreams'", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you use "ficheiro" instead of "bitstream"?
@rsaraivac : If you'd like this to be considered for 8.0 (and backported to 7.x), please address the feedback above. Otherwise, we'll need to reschedule for 9.0 |
Revision and improvement of some of the already existing translation keys upon reviewers’ suggestions.
@paulo-graca : Could you give this a re-review? It looks like your feedback has been addressed. |
@tdonohue Hi, thanks for this reminder and support. I've just reviewed the translations accordingly to the suggestions and introduced some other minor improvements. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @rsaraivac!
Successfully created backport PR for |
Addition of new translation keys (following DSpace 7.6.1 release) & revision/improvement of some of the already existing.
References
Add references/links to any related issues or PRs. These may include:
issue-number
(if this fixes an issue ticket)pr-number
(if a REST API PR is required to test this)Description
Short summary of changes (1-2 sentences).
Instructions for Reviewers
Please add a more detailed description of the changes made by your PR. At a minimum, providing a bulleted list of changes in your PR is helpful to reviewers.
List of changes in this PR:
Include guidance for how to test or review your PR. This may include: steps to reproduce a bug, screenshots or description of a new feature, or reasons behind specific changes.
Checklist
This checklist provides a reminder of what we are going to look for when reviewing your PR. You need not complete this checklist prior to creating your PR (draft PRs are always welcome). If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!
yarn lint
yarn check-circ-deps
)package.json
), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.