Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pt-PT.json5 #2706

Merged
merged 7 commits into from
May 15, 2024
Merged

Update pt-PT.json5 #2706

merged 7 commits into from
May 15, 2024

Conversation

rsaraivac
Copy link
Contributor

Addition of new translation keys (following DSpace 7.6.1 release) & revision/improvement of some of the already existing.

References

Add references/links to any related issues or PRs. These may include:

  • Fixes #issue-number (if this fixes an issue ticket)
  • Requires DSpace/DSpace#pr-number (if a REST API PR is required to test this)

Description

Short summary of changes (1-2 sentences).

Instructions for Reviewers

Please add a more detailed description of the changes made by your PR. At a minimum, providing a bulleted list of changes in your PR is helpful to reviewers.

List of changes in this PR:

  • First, ...
  • Second, ...

Include guidance for how to test or review your PR. This may include: steps to reproduce a bug, screenshots or description of a new feature, or reasons behind specific changes.

Checklist

This checklist provides a reminder of what we are going to look for when reviewing your PR. You need not complete this checklist prior to creating your PR (draft PRs are always welcome). If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!

  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes ESLint validation using yarn lint
  • My PR doesn't introduce circular dependencies (verified via yarn check-circ-deps)
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

Addition of new translation keys (following DSpace 7.6.1 release) & revision/improvement of some of the already existing.
Addition of new translation keys (following DSpace 7.6.1 release) & revision/improvement of some of the already existing.
@rsaraivac rsaraivac reopened this Dec 9, 2023
@rsaraivac rsaraivac closed this Dec 9, 2023
@rsaraivac rsaraivac reopened this Dec 9, 2023
@tdonohue tdonohue added i18n / l10n Internationalisation and localisation, related to message catalogs 1 APPROVAL pull request only requires a single approval to merge port to dspace-7_x This PR needs to be ported to `dspace-7_x` branch for next bug-fix release labels Dec 12, 2023
@paulo-graca paulo-graca self-requested a review December 21, 2023 11:04
Copy link
Contributor

@paulo-graca paulo-graca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @rsaraivac for this contribution! I've just some comments, could you can check if they make sense to you?

@@ -332,6 +335,30 @@
// "admin.registries.schema.title": "Metadata Schema Registry",
"admin.registries.schema.title": "Registo de esquemas de metadados",

// "admin.access-control.bulk-access.breadcrumbs": "Bulk Access Management",
"admin.access-control.bulk-access.breadcrumbs": "Gestão do acesso em lote",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you consider to change to:
"Gestão de permissões" or "Gestão de permissões em lote"

@@ -215,6 +215,9 @@
// "admin.registries.bitstream-formats.title": "Bitstream Format Registry",
"admin.registries.bitstream-formats.title": "Registo de formatos de ficheiro",

// "admin.registries.bitstream-formats.select": "Select bitstream format",
"admin.registries.bitstream-formats.select": "Selecionar formato de 'bitstream'",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you consider to use "ficheiro" to be coeherent?

// "search.filters.namedresourcetype.Workspace": "Workspace",
"search.filters.namedresourcetype.Workspace": "Por terminar",
// "access-control-limit-to-specific": "Limit the changes to specific bitstreams",
"access-control-limit-to-specific": "Limitar as alterações a 'bitstreams' específicos",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you use "ficheiro" instead of "bitstream"?

"access-control-limit-to-specific": "Limitar as alterações a 'bitstreams' específicos",

// "access-control-process-all-bitstreams": "Update all the bitstreams in the item",
"access-control-process-all-bitstreams": "Atualizar todos os 'bitstreams' no item",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you use "ficheiro" instead of "bitstream"?

"access-control-process-all-bitstreams": "Atualizar todos os 'bitstreams' no item",

// "access-control-bitstreams-selected": "bitstreams selected",
"access-control-bitstreams-selected": "bitstreams selecionados",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you use "ficheiro" instead of "bitstream"?

"access-control-bitstreams-selected": "bitstreams selecionados",

// "access-control-bitstreams-select": "Select bitstreams",
"access-control-bitstreams-select": "Selecionar 'bitstreams'",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you use "ficheiro" instead of "bitstream"?

"access-control-remove": "Remover condição de acesso",

// "access-control-select-bitstreams-modal.title": "Select bitstreams",
"access-control-select-bitstreams-modal.title": "Selecionar 'bitstreams'",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you use "ficheiro" instead of "bitstream"?

// "mydspace.status.mydspaceWaitingController": "Waiting for Controller",
"mydspace.status.mydspaceWaitingController": "Aguarda validador",
// "access-control-bitstream-toggle.enable": "Enable option to perform changes on the bitstreams",
"access-control-bitstream-toggle.enable": "Ativar a opção para efetuar alterações nos 'bitstreams'",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you use "ficheiro" instead of "bitstream"?

// "mydspace.status.mydspaceWorkflow": "Workflow",
"mydspace.status.mydspaceWorkflow": "Em fluxo de trabalho",
// "access-control-bitstream-toggle.disable": "Disable option to perform changes on the bitstreams",
"access-control-bitstream-toggle.disable": "Desativar a opção para efetuar alterações nos 'bitstreams'",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you use "ficheiro" instead of "bitstream"?

src/assets/i18n/pt-PT.json5 Outdated Show resolved Hide resolved
@tdonohue
Copy link
Member

@rsaraivac : If you'd like this to be considered for 8.0 (and backported to 7.x), please address the feedback above. Otherwise, we'll need to reschedule for 9.0

Revision and improvement of some of the already existing translation keys upon reviewers’ suggestions.
@tdonohue
Copy link
Member

@paulo-graca : Could you give this a re-review? It looks like your feedback has been addressed.

@tdonohue tdonohue requested a review from paulo-graca May 14, 2024 18:46
@rsaraivac
Copy link
Contributor Author

@paulo-graca : Could you give this a re-review? It looks like your feedback has been addressed.

@rsaraivac : If you'd like this to be considered for 8.0 (and backported to 7.x), please address the feedback above. Otherwise, we'll need to reschedule for 9.0

@tdonohue Hi, thanks for this reminder and support. I've just reviewed the translations accordingly to the suggestions and introduced some other minor improvements.

Copy link
Contributor

@paulo-graca paulo-graca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @rsaraivac!

@tdonohue tdonohue added this to the 8.0 milestone May 15, 2024
@tdonohue tdonohue merged commit 13a33cd into DSpace:main May 15, 2024
12 of 13 checks passed
@dspace-bot
Copy link
Contributor

Successfully created backport PR for dspace-7_x:

@tdonohue tdonohue removed the port to dspace-7_x This PR needs to be ported to `dspace-7_x` branch for next bug-fix release label May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 APPROVAL pull request only requires a single approval to merge i18n / l10n Internationalisation and localisation, related to message catalogs
Projects
No open projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

4 participants